Skip to content

bpo-41207 In distutils.spawn, rewrite FileNotFound#21359

Merged
miss-islington merged 4 commits into
python:masterfrom
jaraco:bugfix/41207-rewrite-filenotfound
Jul 7, 2020
Merged

bpo-41207 In distutils.spawn, rewrite FileNotFound#21359
miss-islington merged 4 commits into
python:masterfrom
jaraco:bugfix/41207-rewrite-filenotfound

Conversation

@jaraco

@jaraco jaraco commented Jul 6, 2020 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

@jaraco jaraco requested a review from vstinner July 6, 2020 20:59
@jaraco jaraco added 🤖 automerge type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir labels Jul 6, 2020
vstinner
vstinner reviewed Jul 7, 2020
View reviewed changes
Comment thread Lib/distutils/tests/test_spawn.py Outdated
Comment thread Misc/NEWS.d/next/Library/2020-07-06-16-58-53.bpo-41207.Emw7Nk.rst Outdated
vstinner
vstinner reviewed Jul 7, 2020
View reviewed changes
Comment thread Lib/distutils/tests/test_spawn.py Outdated
@jaraco

jaraco commented Jul 7, 2020

Copy link
Copy Markdown
Member Author

And in case you weren't aware, the code/test have been committed first to pypa/distutils where I can iterate rapidly, test against multiple Python versions, and simply merge into pypa/setuptools.

vstinner
vstinner approved these changes Jul 7, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix. It's good that the assertRaises(DistutilsExecError) "assumption" is now codified as an actual test ;-)

@jaraco

jaraco commented Jul 7, 2020

Copy link
Copy Markdown
Member Author

Thanks for the prompt and courteous review!

@miss-islington

miss-islington commented Jul 7, 2020

Copy link
Copy Markdown
Contributor

@jaraco: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 6ae2780 into python:master Jul 7, 2020
@miss-islington

miss-islington commented Jul 7, 2020

Copy link
Copy Markdown
Contributor

Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2020
@jaraco @miss-islington
bpo-41207 In distutils.spawn, rewrite FileNotFound (pythonGH-21359)
e6fcc2c 
Automerge-Triggered-By: @jaraco
(cherry picked from commit 6ae2780)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@bedevere-bot

bedevere-bot commented Jul 7, 2020

Copy link
Copy Markdown

GH-21373 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Jul 7, 2020
@miss-islington @jaraco
bpo-41207 In distutils.spawn, rewrite FileNotFound (GH-21359)
2c82628 
Automerge-Triggered-By: @jaraco
(cherry picked from commit 6ae2780)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@jaraco jaraco deleted the bugfix/41207-rewrite-filenotfound branch March 5, 2021 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jaraco @miss-islington @bedevere-bot @vstinner @the-knights-who-say-ni