Skip to content

bpo-31779: Prevent assertion failures and a crash when using an uninitialized struct.Struct object #3984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
orenmn wants to merge 5 commits into from
Closed

bpo-31779: Prevent assertion failures and a crash when using an uninitialized struct.Struct object #3984

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4650244
init commit
orenmn Oct 13, 2017
f8a43d1
make the tests more realistic
orenmn Oct 13, 2017
3f3be9d
check only s_codes
orenmn Oct 13, 2017
e5199f7
remove starting underscore in the helper's name.
orenmn Oct 13, 2017
0e64244
improve the error message
orenmn Oct 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make the tests more realistic
  • Loading branch information
@orenmn
orenmn committed Oct 13, 2017
commit f8a43d1878366264a57ccbf160f8dfd9cb8915d9
6 changes: 3 additions & 3 deletions Lib/test/test_struct.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,10 +632,10 @@ def test_uninitialized(self):
# methods or accessing attributes of an uninitialized Struct object.
s = struct.Struct.__new__(struct.Struct)
self.assertRaises(ValueError, s.iter_unpack, b'foo')
self.assertRaises(ValueError, s.pack)
self.assertRaises(ValueError, s.pack_into)
self.assertRaises(ValueError, s.pack, 42)
self.assertRaises(ValueError, s.pack_into, bytearray(1), 0, 42)
self.assertRaises(ValueError, s.unpack, b'bar')
self.assertRaises(ValueError, s.unpack_from, b'spam')
self.assertRaises(ValueError, s.unpack_from, b'spam', 0)
self.assertRaises(ValueError, s.__sizeof__)
with self.assertRaises(ValueError):
s.format
Expand Down