Sourcery Starbot ⭐ refactored pythoninthegrass/python_template#56
Closed
SourceryAI wants to merge 1 commit into
Closed
Sourcery Starbot ⭐ refactored pythoninthegrass/python_template#56SourceryAI wants to merge 1 commit into
SourceryAI wants to merge 1 commit into
Conversation
SourceryAI
commented
Jun 12, 2023
Comment on lines
-24
to
+27
| rel = "./" + cwd_bn | ||
| rel = f"./{cwd_bn}" | ||
|
|
||
| # add 'CWD=' prefix to rel | ||
| cwd_str = "CWD=" + rel | ||
| cwd_str = f"CWD={rel}" |
Author
There was a problem hiding this comment.
Lines 24-27 refactored with the following changes:
- Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation)
Comment on lines
-10
to
+12
| print("ERROR: The project slug (%s) is not a valid Python module name. Please do not use a - and use _ instead" % module_name) | ||
| print( | ||
| f"ERROR: The project slug ({module_name}) is not a valid Python module name. Please do not use a - and use _ instead" | ||
| ) |
Author
There was a problem hiding this comment.
Lines 10-10 refactored with the following changes:
- Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring)
| assert result.project.isdir() | ||
| run_inside_dir("python setup.py test", str(result.project)) == 0 | ||
| print("test_bake_and_run_tests path", str(result.project)) | ||
| print("test_bake_and_run_tests path", result.project) |
Author
There was a problem hiding this comment.
Function test_bake_and_run_tests refactored with the following changes:
- Remove unnecessary call to
str()withinprint()(remove-str-from-print)
| args = parser.parse_args() | ||
|
|
||
| print("Arguments: " + str(args._)) | ||
| print(f"Arguments: {str(args._)}") |
Author
There was a problem hiding this comment.
Function main refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run: