🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138739

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 09ed5ff with merge base d298bd8 ():

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Glad to see they've finally implemented it

It was actions/checkout#1067

But this other one is still not merged so I don't know if it is an issue for us:
actions/checkout#1454

Glad to see they've finally implemented it

It was actions/checkout#1067

But this other one is still not merged so I don't know if it is an issue for us: actions/checkout#1454

I can update my copy of action to use node20, because looks like checkout step is still much noisier than it used to be. On the other hand, I'm not sure if anyone still cares.
@ezyang is this still an issue to you?

I can update my copy of action to use node20, because looks like checkout step is still much noisier than it used to be

Can you point me to the log?

I've completed the coverage, I don't know if in few cases quiet-checkout was missing already in main

Non hidden progress is annoying but if we need to upgrade I can deal

@ezyang Where are you going to see the new actions logs? I still see the old one

I think that it is still cached and we are using the old one in the CI to test this.

Can we do something to run these new actions in the CI?

Can we try tun run the actions in this PR in the CI? As the CI seems to have ran the old cached one in main.

See the action log:
https://github.com/pytorch/pytorch/actions/runs/11488525801/job/31975420465?pr=138739#step:2:26

I have made a dummy commit. I have also closed and reopened the PR but I still see the CI executing malfet/checkout@silent-checkout

What is the status of this?

Resolved merge conflicts again

There is no interest I am going to close it.

@bhack I believe I've approved it a while back, not sure what happened to it

I've rebased this for two months with 11 messages/requests without reply. It is quite hard to contribute, I have another Docker PR parked and rebased by months.

@pytorchbot merge -f "Lint is green and otherwise it's a no-op"

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Merge failed

Reason: Command `git -C /home/runner/work/pytorch/pytorch commit --author="bhack bhack@users.noreply.github.com" -m Switch back to the default checkout action (#138739)

/cc @malfet

The following actions use a deprecated Node.js version and will be forced to run on node20: malfet/checkout@silent-checkout, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

https://github.com/pytorch/pytorch/actions/runs/11465627688
https://github.com/pytorch/pytorch/actions/runs/11465627688
Pull Request resolved: #138739
Approved by: https://github.com/malfet
` returned non-zero exit code 1

On branch main
Your branch is up to date with 'origin/main'.

nothing to commit, working tree clean

Diverged again

What do you want to do with this?

@malfet it is constantly conflicting merge after merge. Do we want to close it?

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

Too much time for a review since october 2024. I am closing this.