Reject unsupported append mode#1111
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject append mode for
CuFileDriverinstead of pretending it provides safe append semantics.What changed
open(..., "a")with a clearstd::invalid_argumentO_APPENDWhy
CuFileDriverexposes explicit-offsetpread()/pwrite()APIs. That makes append mode a poor fit.The obvious alternative would be to add
O_APPEND, but that is not actually safe here:pwrite()as an explicit-offset writepwrite(2)man page documents that opening a file withO_APPENDcausespwrite()to append regardless of the supplied offsetSo adding
O_APPENDwould make this API more surprising and more dangerous, not less. Rejecting append mode is the cleaner behavior.Validation
test_cufile.cppgit diff --checkFindCUDAToolkitfails to locatenvcc