Skip to content

[Flight] Update stale blocked values in createModelResolver #28669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebmarkbage merged 6 commits into from
Apr 1, 2024
Merged

[Flight] Update stale blocked values in createModelResolver #28669

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6e92c9f
Add a test for issue #28595
unstubbable Mar 20, 2024
4099282
Wrap `Posts` in `Suspense` to differentiate test expectations
unstubbable Mar 23, 2024
5d1bdea
Enhance test to show that b835af277 is not a solution
unstubbable Mar 28, 2024
c578cff
Update stale blocked values in `createModelResolver`
unstubbable Mar 29, 2024
7d5ad2e
Never outline element props in Flight Server
unstubbable Mar 30, 2024
32c5b0b
Cast `value` to `any`
unstubbable Mar 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Cast value to any 
Because of the `$$typeof` check above, we know that this is a react
element.
  • Loading branch information
@unstubbable
unstubbable committed Mar 30, 2024
commit 32c5b0b9d10fe57b2b511c5e958ec5f51f11ff5b
2 changes: 1 addition & 1 deletion packages/react-server/src/ReactFlightServer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1353,7 +1353,7 @@ function renderModelDestructive(
writtenObjects.set(value, SEEN_BUT_NOT_YET_OUTLINED);
// The element's props are marked as "never outlined" so that they are inlined into
// the same row as the element itself.
writtenObjects.set(value.props, NEVER_OUTLINED);
writtenObjects.set((value: any).props, NEVER_OUTLINED);
}

const element: React$Element<any> = (value: any);
Expand Down