Add new error message for awaiting the client export#29853
Merged
sebmarkbage merged 4 commits intoJun 26, 2024
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Comparing: a555419...432b1f0 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
huozhi
force-pushed
the
enhance/update-client-proxy-error-message
branch
from
June 20, 2024 16:12
f7f8451 to
6501ca1
Compare
eps1lon
reviewed
Jun 25, 2024
huozhi
marked this pull request as ready for review
June 25, 2024 09:14
This was referenced Jul 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cannot access .then on serveris not an ideal message when you try to await or do promise chain to the properties of client reference. The below example will let.thenget accessed by native code while handling the promise chain but the access is not clearly visible in user code.This PR chnage the error message of module reference proxy '.then' property to show more kinds of usage, then it can be pretty clearly for helping users to avoid the bad usage
How did you test this change?
Unit test