Skip to content

[compiler][playground] Make change detection work in playground#29889

Merged
mvitousek merged 1 commit into
gh/mvitousek/0/basefrom
gh/mvitousek/0/head
Jun 13, 2024
Merged

[compiler][playground] Make change detection work in playground#29889
mvitousek merged 1 commit into
gh/mvitousek/0/basefrom
gh/mvitousek/0/head

Conversation

@mvitousek

@mvitousek mvitousek commented Jun 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

Summary: The change detection mode was unavailable in the playground because the pragma was not a boolean. This fixes that by special casing it in pragma parsing, similar to validateNoCapitalizedCalls

@mvitousek
[compiler][playground] Make change detection work in playground
8c1b357 
Summary: The change detection mode was unavailable in the playground because the pragma was not a boolean. This fixes that by special casing it in pragma parsing, similar to validateNoCapitalizedCalls

[ghstack-poisoned]
@vercel

vercel Bot commented Jun 13, 2024 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 5:46pm

mvitousek added a commit that referenced this pull request Jun 13, 2024
@mvitousek
[compiler][playground] Make change detection work in playground
a4cd2c7 
Summary: The change detection mode was unavailable in the playground because the pragma was not a boolean. This fixes that by special casing it in pragma parsing, similar to validateNoCapitalizedCalls

ghstack-source-id: 4a8c17d
Pull Request resolved: #29889
@react-sizebot

react-sizebot commented Jun 13, 2024

Copy link
Copy Markdown

Comparing: 55fdcf8...8c1b357

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB +0.05% 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.80 kB 497.80 kB = 89.24 kB 89.24 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.62 kB 502.62 kB = 89.94 kB 89.94 kB
facebook-www/ReactDOM-prod.classic.js = 597.04 kB 597.04 kB = 105.31 kB 105.31 kB
facebook-www/ReactDOM-prod.modern.js = 571.38 kB 571.38 kB = 101.25 kB 101.25 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Generated by 🚫 dangerJS against 8c1b357

@mvitousek
mvitousek merged commit 8c1b357 into gh/mvitousek/0/base Jun 13, 2024
mvitousek added a commit that referenced this pull request Jun 13, 2024
@mvitousek
[compiler][playground] Make change detection work in playground
2ba462b 
Summary: The change detection mode was unavailable in the playground because the pragma was not a boolean. This fixes that by special casing it in pragma parsing, similar to validateNoCapitalizedCalls

ghstack-source-id: 4a8c17d
Pull Request resolved: #29889
@mvitousek
mvitousek deleted the gh/mvitousek/0/head branch June 13, 2024 18:02
@eps1lon eps1lon mentioned this pull request Jul 16, 2024
Closed
This was referenced Jul 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poteto poteto poteto approved these changes

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mvitousek @react-sizebot @poteto @facebook-github-bot