Skip to content

Remove enableAsyncActions #31757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickhanlonii merged 10 commits into from
Dec 13, 2024
Merged

Remove enableAsyncActions #31757

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
30a81df
Remove consoleManagedByDevToolsDuringStrictMode
rickhanlonii Dec 13, 2024
e19682e
fix lint
rickhanlonii Dec 13, 2024
4fc2cfd
Remove disableIEWorkarounds
rickhanlonii Dec 13, 2024
5961888
rm empty describe group
rickhanlonii Dec 13, 2024
617e6d9
fix lint
rickhanlonii Dec 13, 2024
5148c4e
Merge branch 'main' into rh/rm-ff-ie-workarounds
rickhanlonii Dec 13, 2024
2076df7
rm another describe
rickhanlonii Dec 13, 2024
038fdfb
Remove enableAsyncActions
rickhanlonii Dec 13, 2024
2c82664
Merge branch 'main' into rh/rm-ff-asyncactions
rickhanlonii Dec 13, 2024
c23745d
Fixes and Dispatcher type
rickhanlonii Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove consoleManagedByDevToolsDuringStrictMode
  • Loading branch information
@rickhanlonii
rickhanlonii committed Dec 13, 2024
commit 30a81df1c1846e6f9e9c92815e0f5fe7eca6a449
42 changes: 15 additions & 27 deletions packages/react-reconciler/src/ReactFiberDevToolsHook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ type DevToolsProfilingHooks = any;

import {DidCapture} from './ReactFiberFlags';
import {
consoleManagedByDevToolsDuringStrictMode,
enableProfilerTimer,
enableSchedulingProfiler,
} from 'shared/ReactFeatureFlags';
Expand Down Expand Up @@ -188,36 +187,25 @@ export function onCommitUnmount(fiber: Fiber) {
}

export function setIsStrictModeForDevtools(newIsStrictMode: boolean) {
if (consoleManagedByDevToolsDuringStrictMode) {
if (typeof log === 'function') {
// We're in a test because Scheduler.log only exists
// in SchedulerMock. To reduce the noise in strict mode tests,
// suppress warnings and disable scheduler yielding during the double render
unstable_setDisableYieldValue(newIsStrictMode);
setSuppressWarning(newIsStrictMode);
}
if (typeof log === 'function') {
// We're in a test because Scheduler.log only exists
// in SchedulerMock. To reduce the noise in strict mode tests,
// suppress warnings and disable scheduler yielding during the double render
unstable_setDisableYieldValue(newIsStrictMode);
setSuppressWarning(newIsStrictMode);
}

if (injectedHook && typeof injectedHook.setStrictMode === 'function') {
try {
injectedHook.setStrictMode(rendererID, newIsStrictMode);
} catch (err) {
if (__DEV__) {
if (!hasLoggedError) {
hasLoggedError = true;
console.error(
'React instrumentation encountered an error: %s',
err,
);
}
if (injectedHook && typeof injectedHook.setStrictMode === 'function') {
try {
injectedHook.setStrictMode(rendererID, newIsStrictMode);
} catch (err) {
if (__DEV__) {
if (!hasLoggedError) {
hasLoggedError = true;
console.error('React instrumentation encountered an error: %s', err);
}
}
}
} else {
if (newIsStrictMode) {
disableLogs();
} else {
reenableLogs();
}
}
}

Expand Down
Loading