base58: Add len and is_empty to Base58CkString#6526
Open
mpbagot wants to merge 2 commits into
Open
Conversation
The Base58CkString type is essentially treated like a string in some cases. While users can cast to a &str with as_str, it is convenient to instead provide len and is_empty functions for the user. Add len and is_empty methods to the Base58CkString type.
With the new .len() function, the previous .as_str().len() use in the address tests can now be shortened to a single .len() call instead. Replace encoded.as_str().len() with encoded.len() in base58_invalid_payload_length_reports_decoded_size test in address module.
tcharding
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Base58CkString type is essentially treated like a string in some cases. While users can cast to a &str with as_str, it is convenient to instead provide len and is_empty functions for the user.
Add len and is_empty methods to the Base58CkString type.