Clear out memoized hashes before building crates#7373
Merged
Conversation
Build script updates during execution can change the memoized hash of a `Fingerprint`, and while previously we cleared out a single build script's memoized hash we forgot to clear out everything that depended on it as well. This commit pessimistically clears out all `Fingerprint` memoized hashes just before building to ensure that during the build everything has the most up-to-date view of the world, and when build scripts change fingerprints everything that depends on them won't have run yet. Closes rust-lang#7362
|
r? @ehuss (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
Thanks! @bors r+ |
Contributor
|
📌 Commit c3868bb has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Sep 17, 2019
Clear out memoized hashes before building crates Build script updates during execution can change the memoized hash of a `Fingerprint`, and while previously we cleared out a single build script's memoized hash we forgot to clear out everything that depended on it as well. This commit pessimistically clears out all `Fingerprint` memoized hashes just before building to ensure that during the build everything has the most up-to-date view of the world, and when build scripts change fingerprints everything that depends on them won't have run yet. Closes #7362
Contributor
|
☀️ Test successful - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build script updates during execution can change the memoized hash of a
Fingerprint, and while previously we cleared out a single buildscript's memoized hash we forgot to clear out everything that depended
on it as well. This commit pessimistically clears out all
Fingerprintmemoized hashes just before building to ensure that during the build
everything has the most up-to-date view of the world, and when build
scripts change fingerprints everything that depends on them won't have
run yet.
Closes #7362