Skip to content

Allow failure when setting file mtime.#8185

Merged
bors merged 1 commit into
rust-lang:masterfrom
ehuss:allow-mtime-failure
Apr 30, 2020
Merged

Allow failure when setting file mtime.#8185
bors merged 1 commit into
rust-lang:masterfrom
ehuss:allow-mtime-failure

Conversation

@ehuss

@ehuss ehuss commented Apr 30, 2020

Copy link
Copy Markdown
Contributor

Some filesystems do not allow changing file mtimes (most recent example is a Windows mount in WSL). Since these operations are not critical to Cargo's operation, errors should probably just be ignored. (Currently they are used for mid-build modification protection, and the unstable mtime-on-use).

Fixes #8184

@rust-highfive

Copy link
Copy Markdown

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 30, 2020
@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Apr 30, 2020

Copy link
Copy Markdown
Contributor

📌 Commit 5f9d9f2 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 30, 2020
@bors

bors commented Apr 30, 2020

Copy link
Copy Markdown
Contributor

⌛ Testing commit 5f9d9f2 with merge ba832ac...

@bors

bors commented Apr 30, 2020

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing ba832ac to master...

@bors bors merged commit ba832ac into rust-lang:master Apr 30, 2020
@ehuss ehuss added this to the 1.45.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rust unable to perform cargo run and cargo build on WSL

4 participants