Skip to content

Update GitHub Actions actions/checkout@v2 to v3#2092

Merged
bors merged 1 commit into
rust-lang:masterfrom
dtolnay-contrib:checkoutv3
Apr 30, 2022
Merged

Update GitHub Actions actions/checkout@v2 to v3#2092
bors merged 1 commit into
rust-lang:masterfrom
dtolnay-contrib:checkoutv3

Conversation

@dtolnay

@dtolnay dtolnay commented Apr 30, 2022

Copy link
Copy Markdown
Member

The v2 implementation uses Node 12, which is end-of-life on April 30, 2022. See https://nodejs.org/en/about/releases/. Update to v3, which is based on Node 16 whose support lasts until April 30, 2024.

The v2 implementation uses Node 12, which is end-of-life on April 30, 2022.
See https://nodejs.org/en/about/releases/. Update to v3, which is based on
Node 16 whose support lasts until April 30, 2024.
@oli-obk

oli-obk commented Apr 30, 2022

Copy link
Copy Markdown
Contributor

@bors r+

It probably would've worked beyond today, just been unsupported, right?

@bors

bors commented Apr 30, 2022

Copy link
Copy Markdown
Contributor

📌 Commit 0bdf91d has been approved by oli-obk

@bors

bors commented Apr 30, 2022

Copy link
Copy Markdown
Contributor

⌛ Testing commit 0bdf91d with merge 0fce9f4...

@bors

bors commented Apr 30, 2022

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 0fce9f4 to master...

@bors bors merged commit 0fce9f4 into rust-lang:master Apr 30, 2022
@RalfJung

RalfJung commented Apr 30, 2022

Copy link
Copy Markdown
Member

Is there any user-visible change in behavior?
(I am trying to understand why this Node update was considered a breaking change in terms of semver.)

@bjorn3

bjorn3 commented Apr 30, 2022

Copy link
Copy Markdown
Member

actions/checkout#689 (comment): looks like it is because older github enterprise versions don't support nodejs 16 and thus bumping actions/checkout to nodejs 16 would break them.

@dtolnay dtolnay deleted the checkoutv3 branch April 30, 2022 16:28
pull Bot pushed a commit to xtqqczze/rust-lang-miri that referenced this pull request May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants