Skip to content

add ./x clippy ci #132649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 4 commits into from
Nov 14, 2024
Merged

add ./x clippy ci #132649

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6729186
store the lint levels in the clippy structs themselves
emilyalbini Jun 12, 2024
3c68417
define all the clippy lints we check in CI in a step
emilyalbini Jun 12, 2024
dad667b
fix tests
klensy Nov 5, 2024
cdd948c
fix clippy warns on windows (not checked by CI)
klensy Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix clippy warns on windows (not checked by CI)
  • Loading branch information
@klensy
klensy committed Nov 13, 2024
commit cdd948cbc05f00bcf072808c8659b5fc6e0ab196
2 changes: 2 additions & 0 deletions src/bootstrap/src/core/build_steps/clean.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,8 @@ where
Err(ref e) if e.kind() == ErrorKind::PermissionDenied => {
let m = t!(path.symlink_metadata());
let mut p = m.permissions();
// this os not unix, so clippy gives FP
#[expect(clippy::permissions_set_readonly_false)]
p.set_readonly(false);
t!(fs::set_permissions(path, p));
f(path).unwrap_or_else(|e| {
Expand Down
2 changes: 1 addition & 1 deletion src/bootstrap/src/utils/helpers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ pub fn symlink_dir(config: &Config, original: &Path, link: &Path) -> io::Result<

#[cfg(windows)]
fn symlink_dir_inner(target: &Path, junction: &Path) -> io::Result<()> {
junction::create(&target, &junction)
junction::create(target, junction)
}
}

Expand Down