Skip to content

Suppress run-make subprocess output (incl. fences) when --verbose-run-make-subprocess-output=false#156890

Open
jieyouxu wants to merge 1 commit into
rust-lang:mainfrom
jieyouxu:jieyouxu/fix/run-make-extra-fence
Open

Suppress run-make subprocess output (incl. fences) when --verbose-run-make-subprocess-output=false#156890
jieyouxu wants to merge 1 commit into
rust-lang:mainfrom
jieyouxu:jieyouxu/fix/run-make-extra-fence

Conversation

@jieyouxu

@jieyouxu jieyouxu commented May 24, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Fixes #156276.

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 24, 2026
@rustbot

rustbot commented May 24, 2026

Copy link
Copy Markdown
Collaborator

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @jieyouxu, @oli-obk, @wesleywiser, bootstrap
  • @jieyouxu, @oli-obk, @wesleywiser, bootstrap expanded to 8 candidates
  • Random selection from Mark-Simulacrum, clubby789, oli-obk, wesleywiser

@jieyouxu

jieyouxu commented May 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

@bjorn3 can u help me check if this behavior is what you want re. #156276?

@jieyouxu

jieyouxu commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

r? bjorn3

@rustbot rustbot assigned bjorn3 and unassigned wesleywiser Jun 5, 2026
@bjorn3

bjorn3 commented Jun 11, 2026

Copy link
Copy Markdown
Member

Wouldn't this also suppress the output in case of a failure?

@jieyouxu

jieyouxu commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

Hm... let me double check.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@bjorn3 bjorn3

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

run-make: extraneous cg_clif test output fences

4 participants

@jieyouxu @rustbot @bjorn3 @wesleywiser