Misc. fmt_type cleanups#157584
Open
yotamofek wants to merge 1 commit into
Open
Conversation
GuillaumeGomez
approved these changes
Jun 7, 2026
Member
|
I gladly take it, nice improvement! r=me once CI pass. |
This comment has been minimized.
This comment has been minimized.
fmease
reviewed
Jun 7, 2026
| } | ||
| clean::ImplTrait(ref bounds) if bounds.len() > 1 => true, | ||
| let needs_parens = match ty { | ||
| clean::DynTrait(bounds, Some(_)) if bounds.len() > 1 => true, |
Member
There was a problem hiding this comment.
This is not equivalent to what was there before. It's now bounds.len() > 1 && trait_lt.is_some() essentially whereas before it was bounds.len() > 1 || trait_lt.is_some()
Contributor
Author
There was a problem hiding this comment.
Yep, thanks!
(That, and a few other places where turning a x.fmt(f) into a write!(f, "{}", x) caused the alternate-ness to be lost)
b414dae to
17eddd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @GuillaumeGomez if you want it :)