Skip to content

Perf test extending int args in x86 Rust ABI#159353

Draft
workingjubilee wants to merge 7 commits into
rust-lang:mainfrom
workingjubilee:perf-test-for-x86-argext-rust-abi
Draft

Perf test extending int args in x86 Rust ABI#159353
workingjubilee wants to merge 7 commits into
rust-lang:mainfrom
workingjubilee:perf-test-for-x86-argext-rust-abi

Conversation

@workingjubilee

@workingjubilee workingjubilee commented Jul 15, 2026

Copy link
Copy Markdown
Member

No description provided.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 15, 2026
@workingjubilee workingjubilee mentioned this pull request Jul 15, 2026
Open
@workingjubilee

workingjubilee commented Jul 15, 2026

Copy link
Copy Markdown
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 15, 2026
rust-bors Bot pushed a commit that referenced this pull request Jul 15, 2026
@bors
Auto merge of #159353 - workingjubilee:perf-test-for-x86-argext-rust-…
33b71f4 
…abi, r=<try>

Perf test extending int args in x86 Rust ABI
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 33b71f4 (33b71f40e6d9da2bc699ef75dc9ef64ce6a607c8)
Base parent: 2118366 (2118366bbfe2e57ec0e8417ea270833e9f013640)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer

rust-timer commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (33b71f4): comparison URL.

Overall result: ❌ regressions - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never rustc-perf
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 0.4% [0.3%, 0.5%] 5
Regressions ❌
(secondary)		 0.6% [0.2%, 1.0%] 6
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.4% [0.3%, 0.5%] 5

Max RSS (memory usage)

Results (secondary 2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results (primary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.5% [-2.5%, -2.4%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.5% [-2.5%, -2.4%] 2

Binary size

Results (primary 0.0%, secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 0.0% [0.0%, 0.0%] 4
Regressions ❌
(secondary)		 0.0% [0.0%, 0.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.0% [0.0%, 0.0%] 4

Bootstrap: 490.55s -> 488.601s (-0.40%)
Artifact size: 390.05 MiB -> 390.01 MiB (-0.01%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 16, 2026
@workingjubilee

workingjubilee commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

The negative impact only seems to affect some debug builds so I wonder if the hit is just literally doing more work on every Rust function signature.

@workingjubilee workingjubilee force-pushed the perf-test-for-x86-argext-rust-abi branch from fec6880 to 05c663a Compare July 16, 2026 00:58
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@workingjubilee workingjubilee force-pushed the perf-test-for-x86-argext-rust-abi branch from 05c663a to 740b302 Compare July 16, 2026 01:18
@workingjubilee

workingjubilee commented Jul 16, 2026

Copy link
Copy Markdown
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 16, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jul 16, 2026
@bors
Auto merge of #159353 - workingjubilee:perf-test-for-x86-argext-rust-…
eea949d 
…abi, r=<try>

Perf test extending int args in x86 Rust ABI
@rust-bors

rust-bors Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: eea949d (eea949dbe8d689fbb2b63679a74fa1db95af0d33)
Base parent: d0babd8 (d0babd8b6b05ef9bb65d42f928cef4129d64cf65)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer

rust-timer commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (eea949d): comparison URL.

Overall result: ❌ regressions - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never rustc-perf
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 0.4% [0.3%, 0.5%] 8
Regressions ❌
(secondary)		 0.6% [0.2%, 1.0%] 6
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.4% [0.3%, 0.5%] 8

Max RSS (memory usage)

Results (secondary 3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.1% [3.1%, 3.1%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results (secondary -1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.4% [3.4%, 3.4%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.4% [-6.0%, -2.8%] 2
All ❌✅ (primary) - - 0

Binary size

Results (primary 0.0%, secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 0.0% [0.0%, 0.0%] 4
Regressions ❌
(secondary)		 0.0% [0.0%, 0.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.0% [0.0%, 0.0%] 4

Bootstrap: 491.731s -> 490.98s (-0.15%)
Artifact size: 390.07 MiB -> 389.48 MiB (-0.15%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

perf-regression Performance regression. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@workingjubilee @rust-timer @rust-log-analyzer @rustbot