Skip to content

s390x: add vec_sub, vec_mul, vec_min, vec_max, vec_abs and vec_splats #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Amanieu merged 6 commits into from
Feb 7, 2025
Merged

s390x: add vec_sub, vec_mul, vec_min, vec_max, vec_abs and vec_splats #1704

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0bfb5ec
implement `VectorAdd` for `s390x`
folkertdev Jan 18, 2025
8e56093
add `vec_sub` and `vec_mul` for s390x
folkertdev Jan 19, 2025
82b3739
add `vec_max` and `vec_min` for s390x
folkertdev Jan 20, 2025
b738823
add `vec_abs` for s390x
folkertdev Jan 20, 2025
e3e14c7
add `vec_splats` for s390x
folkertdev Jan 20, 2025
8f1a215
some doc changes
folkertdev Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add vec_abs for s390x
  • Loading branch information
@folkertdev
folkertdev committed Jan 21, 2025
commit b7388230c49a8b462aef9de3eb6df04e1dcf8842
54 changes: 53 additions & 1 deletion crates/core_arch/src/s390x/vector.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,6 @@ mod sealed {
impl_mul!(vml_double, vector_double, vfmdb);
}


#[unstable(feature = "stdarch_s390x", issue = "135681")]
pub trait VectorMax<Other> {
type Result;
Expand Down Expand Up @@ -344,6 +343,48 @@ mod sealed {
test_impl! { vec_vmnslg (a: vector_unsigned_long_long, b: vector_unsigned_long_long) -> vector_unsigned_long_long [vmnlg, vmnlg] }

impl_vec_trait! { [VectorMin vec_min] ~(vmxlb, vmxb, vmxlh, vmxh, vmxlf, vmxf, vmxlg, vmxg) }

#[unstable(feature = "stdarch_s390x", issue = "135681")]
pub trait VectorAbs {
unsafe fn vec_abs(self) -> Self;
}

macro_rules! impl_abs {
($name:ident, $ty:ident, $instr:ident) => {
#[inline]
#[target_feature(enable = "vector")]
#[cfg_attr(test, assert_instr($instr))]
unsafe fn $name(v: s_t_l!($ty)) -> s_t_l!($ty) {
v.vec_max(-v)
}

impl_vec_trait! { [VectorAbs vec_abs] $name (s_t_l!($ty)) }
};
}

impl_abs! { vec_abs_i8, i8x16 }
impl_abs! { vec_abs_i16, i16x8 }
impl_abs! { vec_abs_i32, i32x4 }
impl_abs! { vec_abs_i64, i64x2 }

#[inline]
#[target_feature(enable = "vector")]
unsafe fn vec_abs_f32(v: vector_float) -> vector_float {
let v: u32x4 = transmute(v);

transmute(simd_and(v, u32x4::splat(0x7FFFFFFF)))
}

#[inline]
#[target_feature(enable = "vector")]
unsafe fn vec_abs_f64(v: vector_double) -> vector_double {
let v: u64x2 = transmute(v);

transmute(simd_and(v, u64x2::splat(0x7FFFFFFF_FFFFFFFF)))
}

impl_vec_trait! { [VectorAbs vec_abs] vec_abs_f32 (vector_float) }
impl_vec_trait! { [VectorAbs vec_abs] vec_abs_f64 (vector_double) }
}

/// Vector pointwise addition.
Expand Down Expand Up @@ -407,6 +448,17 @@ where
a.vec_min(b)
}

/// Vector abs.
#[inline]
#[target_feature(enable = "vector")]
#[unstable(feature = "stdarch_s390x", issue = "135681")]
pub unsafe fn vec_abs<T>(a: T) -> T
where
T: sealed::VectorAbs,
{
a.vec_abs()
}

#[cfg(test)]
mod tests {
use super::*;
Expand Down