Skip to content

Expand condition_script_runner_args#1132

Merged
sagiegurari merged 16 commits into
sagiegurari:masterfrom
wmmc88:expand-condition-script-args
Aug 18, 2024
Merged

Expand condition_script_runner_args#1132
sagiegurari merged 16 commits into
sagiegurari:masterfrom
wmmc88:expand-condition-script-args

Conversation

@wmmc88

@wmmc88 wmmc88 commented Jul 31, 2024

Copy link
Copy Markdown
Contributor

#1081 added condition_script_runner_args, but condition_script_runner_args didn't expand env vars like script_runner_args did. This PR adds env expansion to condition_script_runner_args, and also adds tests for it.

Various bugfixes to tests were also fixed in order for cargo make ci-flow to pass on:

  1. windows computers
  2. environments that set CARGO_HOME

wmmc88
wmmc88 commented Jul 31, 2024
View reviewed changes
Comment thread src/lib/runner.rs Outdated
@sagiegurari

sagiegurari commented Aug 3, 2024

Copy link
Copy Markdown
Owner

@wmmc88 thanks for the PR! would love if you see my comment

wmmc88
wmmc88 commented Aug 4, 2024
View reviewed changes
Comment thread README.md
@wmmc88

wmmc88 commented Aug 5, 2024

Copy link
Copy Markdown
Contributor Author

@wmmc88 thanks for the PR! would love if you see my comment

@sagiegurari I've updated the PR so that there is no change in env when condition evaluation fails (and added a test to prevent possible future regressions)

@wmmc88 wmmc88 requested a review from sagiegurari August 8, 2024 15:33
@wmmc88 wmmc88 mentioned this pull request Aug 8, 2024
Merged
@wmmc88

wmmc88 commented Aug 12, 2024

Copy link
Copy Markdown
Contributor Author

@sagiegurari friendly ping to review this :) the underlying bug is a blocker for me

This was referenced Aug 15, 2024
Closed
Closed
@sagiegurari

sagiegurari commented Aug 16, 2024

Copy link
Copy Markdown
Owner

@wmmc88 sorry for the delay! i'll go over it today

sagiegurari
sagiegurari requested changes Aug 16, 2024
View reviewed changes

@sagiegurari sagiegurari left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wmmc88 everything looks pretty great just 2 main thinigs

  1. docs - the file is generated so your changes will be deleted. lets try not to do the nav changes you did but only the content. you can add nav, but not add a new root please.
  2. env setup before the condition and restoring it causes new env vars defined in the task to stick even if condition fails. we need to remove them.

Comment thread README.md
Comment thread src/lib/runner.rs Outdated
@codecov

codecov Bot commented Aug 18, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 19.78022% with 73 lines in your changes missing coverage. Please review.

Project coverage is 69.01%. Comparing base (6193a27) to head (092fea3).
Report is 18 commits behind head on master.

Files Patch % Lines
src/lib/runner_test.rs 0.00% 51 Missing ⚠️
src/lib/environment/mod_test.rs 0.00% 21 Missing ⚠️
src/lib/environment/mod.rs 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #1132       +/-   ##
===========================================
- Coverage   92.81%   69.01%   -23.80%     
===========================================
  Files         119      119               
  Lines       26224    26347      +123     
===========================================
- Hits        24339    18183     -6156     
- Misses       1885     8164     +6279

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wmmc88 wmmc88 requested a review from sagiegurari August 18, 2024 05:15
@wmmc88

wmmc88 commented Aug 18, 2024

Copy link
Copy Markdown
Contributor Author

@sagiegurari I think I've resolved all your requested changes

@sagiegurari sagiegurari self-assigned this Aug 18, 2024
@sagiegurari sagiegurari merged commit b639e7d into sagiegurari:master Aug 18, 2024
@sagiegurari

sagiegurari commented Aug 18, 2024

Copy link
Copy Markdown
Owner

Thanks a lot @wmmc88 for the PR. merged.
I'll probably release a new version at end of week.
sorry it took so long.

@wmmc88 wmmc88 deleted the expand-condition-script-args branch August 18, 2024 15:08
@wmmc88

wmmc88 commented Aug 25, 2024

Copy link
Copy Markdown
Contributor Author

Thanks a lot @wmmc88 for the PR. merged. I'll probably release a new version at end of week. sorry it took so long.

Hi @sagiegurari! friendly bump for a release

@wmmc88 wmmc88 mentioned this pull request Aug 26, 2024
Merged
@sagiegurari

sagiegurari commented Aug 30, 2024

Copy link
Copy Markdown
Owner

@wmmc88 sorry for really late handling of this but 0.37.16 is now released with this fix. thanks for the pr

This was referenced Sep 2, 2024
Merged
Merged
@wmmc88 wmmc88 mentioned this pull request Sep 4, 2024
Open
@wmmc88 wmmc88 mentioned this pull request Oct 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sagiegurari sagiegurari Awaiting requested review from sagiegurari

Assignees

@sagiegurari sagiegurari

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wmmc88 @sagiegurari