rename --reconstruct-historic-states to --archive#8795
Conversation
Rename the CLI flag and the internal config field to the shorter `--archive` name. The old `--reconstruct-historic-states` flag is kept as a hidden alias for backwards compatibility. Update documentation and tests accordingly.
michaelsproul
left a comment
There was a problem hiding this comment.
Looks good. The only change I can think of that's missing is a deprecation warning for the old flag. Unless we don't want to deprecate it yet?
| .long("reconstruct-historic-states") | ||
| Arg::new("archive") | ||
| .long("archive") | ||
| .alias("reconstruct-historic-states") |
There was a problem hiding this comment.
Technically this description is wrong, the flag is now also relevant for genesis sync. Maybe we could state something general like "store all states" and elaborate that for checkpoint sync it means the states will be reconstructed after backfill completes
accf986 to
f329c9e
Compare
|
Updated the help text to be more general: "Store all beacon states in the database. When checkpoint syncing, states are reconstructed after backfill completes." Re deprecation: we'd prefer to keep |
michaelsproul
left a comment
There was a problem hiding this comment.
Looks good now, thanks!
I'll label this as backwards-incompat (even though it isn't technically) so it gets flagged for a mention in the release notes.
Merge Queue StatusRule:
This pull request spent 29 minutes 42 seconds in the queue, including 28 minutes 2 seconds running CI. Required conditions to merge
|
Summary
--reconstruct-historic-statesCLI flag to--archive--reconstruct-historic-statesas a hidden alias for backwards compatibilityreconstruct_historic_statestoarchiveTest plan
cargo checkpassescargo fmtcleanmake lint-fullpasses (ran via pre-push hook)archive_flag,archive_flag_alias,no_archive_flag,genesis_backfill_with_archive_flag@dapplion
spec'ed by me, written by opus 4.6, manually reviewed by me