Skip to content

Remove SHA256 assumption in sign-blob/verify-blob #4050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hayden-IO merged 26 commits into from
Sep 2, 2025
Merged

Remove SHA256 assumption in sign-blob/verify-blob #4050

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
b1c0f19
Remove SHA256 assumption in sign-blob/verify-blob
ret2libc Mar 4, 2025
180d536
Use Ed25519ph by default
ret2libc Mar 5, 2025
bb0a4bd
tests: add e2e test for sign-blob/verify-blob with non-default keys
ret2libc Mar 5, 2025
260444c
Update sigstore/sigstore to v1.9.1
ret2libc Mar 12, 2025
45f0289
REMOVE ME: Update to trail-of-forks sigstore-go
ret2libc Mar 12, 2025
2040109
fix tests
ret2libc Mar 12, 2025
00d769a
fix e2e tests
ret2libc Mar 12, 2025
acfa016
Use PureED25519 if no tlog upload
ret2libc Mar 13, 2025
8234ba5
fulcio: add comment about adapter
ret2libc Mar 13, 2025
1bc2269
test/e2e_test: use rekorUrl/fulcioUrl
ret2libc Mar 13, 2025
1f86890
REMOVE ME: update sigsto-go
ret2libc Apr 2, 2025
ab1b104
Merge remote-tracking branch 'origin/main' into use-load-options
ret2libc Apr 2, 2025
2961ce1
REMOVE ME: update sigstore-go
ret2libc Apr 2, 2025
dd4c926
test: try to fix e2e tests
ret2libc Apr 4, 2025
1b82e30
test/e2e_test: correctly name subtests
ret2libc Apr 4, 2025
3a8c7e2
fix e2e tests
ret2libc Apr 7, 2025
d6ef62b
fix lint
ret2libc Apr 7, 2025
208c3d5
fix lint 2
ret2libc Apr 7, 2025
c9ec1b7
extract GetDefaultLoadOptions function
ret2libc Apr 8, 2025
b7ab2fb
Merge remote-tracking branch 'origin/main' into use-load-options
ret2libc Apr 8, 2025
f0dd4d1
Merge remote-tracking branch 'origin/main' into use-load-options
ret2libc Jul 1, 2025
b4ea782
add a confirmation msg for old bundle format
ret2libc Jul 1, 2025
590c216
Merge remote-tracking branch 'origin/main' into use-load-options
ret2libc Aug 26, 2025
126a039
fix merging, payload needs to be initialized earlier
ret2libc Aug 27, 2025
c4f824e
Provide a default SHA256 payload for signingConfig payload
ret2libc Aug 28, 2025
3fb2bb7
fix lint
ret2libc Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: try to fix e2e tests 
Signed-off-by: Riccardo Schirone <riccardo.schirone@trailofbits.com>
  • Loading branch information
@ret2libc
ret2libc committed Apr 4, 2025
commit dd4c92655903f063bfdaf8c942069b5ed4b460a4
12 changes: 12 additions & 0 deletions test/e2e_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2275,6 +2275,16 @@ func TestSignBlobNewBundleNonDefaultAlgorithm(t *testing.T) {
{v1.PublicKeyDetails_PKIX_ED25519_PH},
}

err := fulcioroots.ReInit()
if err != nil {
t.Fatal(err)
}

identityToken, err := getOIDCToken()
if err != nil {
t.Fatal(err)
}

for _, tt := range tts {
td1 := t.TempDir()

Expand All @@ -2292,6 +2302,7 @@ func TestSignBlobNewBundleNonDefaultAlgorithm(t *testing.T) {
ko1 := options.KeyOpts{
FulcioURL: fulcioURL,
RekorURL: rekorURL,
IDToken: identityToken,
KeyRef: pubKeyPath,
BundlePath: bundlePath,
NewBundleFormat: true,
Expand All @@ -2310,6 +2321,7 @@ func TestSignBlobNewBundleNonDefaultAlgorithm(t *testing.T) {
ko := options.KeyOpts{
FulcioURL: fulcioURL,
RekorURL: rekorURL,
IDToken: identityToken,
KeyRef: privKeyPath,
PassFunc: passFunc,
BundlePath: bundlePath,
Expand Down