Initialize PKCS11 slots Before Getting Token Info#4803
Merged
Conversation
Signed-off-by: Kynson Szetau <46522440+Kynson@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4803 +/- ##
==========================================
- Coverage 40.10% 37.76% -2.35%
==========================================
Files 155 220 +65
Lines 10044 12918 +2874
==========================================
+ Hits 4028 4878 +850
- Misses 5530 7303 +1773
- Partials 486 737 +251 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a backup for #4770. Some PKCS11 module (like YKCS11 from yubico key) requires initialization before calling
GetTokenInfo. This PR can be tested with a yubico key and YKCS11.Fixes #4768
Release Note
Fixed the issue where
cosigncrashes when runningpkcs11-tool list-keys-uriswith YKCS11 module.Documentation
N/A