Add support for PSR-18 HTTP clients#777
Merged
Merged
Conversation
This was referenced Jan 27, 2023
Art4
commented
Feb 16, 2023
| * @param File $file Input file | ||
| */ | ||
| public function __construct(File $file) | ||
| public function __construct(/* File */ $file) |
Contributor
Author
There was a problem hiding this comment.
Removing the type hint is not a breaking change because we have not released 1.9.0 yet.
Contributor
Author
|
This PR is ready for review. Because this PR is build on #774 I recommend to merge this PR first. It will fix some BC breaks that comes with #774. To show only the changes between #774 and #777 you can look at the diff between the branches: Art4/simplepie@split-file-into-client-and-response...Art4:simplepie:add-psr18-http-client-support |
jtojnar
requested changes
Jun 12, 2023
jtojnar
left a comment
Member
There was a problem hiding this comment.
Still need to resolve the question of non-absolute Location header and Redirect tracking.
| $requestedUrl = $response->getHeaderLine('Location'); | ||
|
|
||
| if ($statusCode === 301) { | ||
| $permanentUrl = $requestedUrl; |
Member
|
thanks @Art4 this looks good, can we merge and handle the redirect case separately? |
Contributor
Author
|
@mblaney I resolved all conflicts and fixed all PHPStan errors. |
jtojnar
added a commit
to jtojnar/simplepie
that referenced
this pull request
Nov 6, 2023
…ent-support" There are correctness issues as well as disorganized commit history. The fixed changes are re-applied in the commits that follow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all 👋
This is a follow up of #774 and will add support for every PSR-18 HTTP client implementation. 🥳
This PR will fixes #520. I propose this PR for SimplePie 1.9.0, see #731.