Skip to content

[Resources] Max Hourly Cost#9132

Merged
kyuds merged 7 commits into
masterfrom
kyuds/max-hourly-cost
Mar 23, 2026
Merged

[Resources] Max Hourly Cost#9132
kyuds merged 7 commits into
masterfrom
kyuds/max-hourly-cost

Conversation

@kyuds

@kyuds kyuds commented Mar 19, 2026

Copy link
Copy Markdown
Collaborator

Resolve #8766

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

@gemini-code-assist

gemini-code-assist Bot commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances resource provisioning capabilities by introducing a max_hourly_cost parameter. This allows users to define a ceiling for instance costs, which the system then uses in conjunction with spot instance preferences to intelligently select the most cost-effective instance types. The changes are integrated throughout the resource catalog and cloud provider modules, ensuring that cost considerations are a primary factor in instance selection.

Highlights

  • New Feature: Max Hourly Cost: Introduced a new max_hourly_cost parameter across the resource catalog and cloud provider interfaces, allowing users to specify a maximum hourly cost for instances.
  • Instance Selection Logic Enhancement: Modified the instance type selection logic to filter and sort available instance types based on the specified max_hourly_cost and use_spot flag, prioritizing the cheapest options within budget constraints.
  • API and SDK Updates: Updated the API version and SDK to support the new max_hourly_cost field, ensuring backward compatibility and proper handling of this parameter in resource definitions.
  • Cloud Provider Integration: Propagated the max_hourly_cost parameter through various cloud catalog and cloud provider functions (AWS, Azure, GCP, etc.) to enable consistent cost-aware resource provisioning.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@kyuds kyuds mentioned this pull request Mar 19, 2026
Closed
5 tasks
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 19, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces max_hourly_cost as a new parameter across various catalog and cloud provider files, allowing users to specify a maximum hourly cost for instances. This new parameter is integrated into resource selection logic, particularly for filtering and sorting instances based on price. The API version has been updated, and backward compatibility for older API servers is handled. Overall, the changes are well-integrated and extend the resource management capabilities.

Comment thread sky/catalog/common.py
Comment thread sky/catalog/common.py
@kevinmingtarja kevinmingtarja self-assigned this Mar 23, 2026
@kevinmingtarja kevinmingtarja self-requested a review March 23, 2026 17:26
@kevinmingtarja kevinmingtarja removed their assignment Mar 23, 2026
kevinmingtarja
kevinmingtarja approved these changes Mar 23, 2026
View reviewed changes

@kevinmingtarja kevinmingtarja left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kyuds! let's run quicktest before we merge

@kyuds

kyuds commented Mar 23, 2026

Copy link
Copy Markdown
Collaborator Author

/quicktest-core

@kyuds kyuds merged commit a64cee4 into master Mar 23, 2026
23 checks passed
@kyuds kyuds deleted the kyuds/max-hourly-cost branch March 23, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinmingtarja kevinmingtarja kevinmingtarja approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request] Add max_hourly_cost budget control for instance selection

2 participants

@kyuds @kevinmingtarja