[Kubernetes] Remove all_includes_in_cluster from skypilot config#9671
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Michaelvll
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove all_includes_in_cluster from skypilot config.
Tested (run the relevant ones):
bash format.shSet
allowed_contexts: allin SkyPilot configSKYPILOT_ALL_KUBERNETES_CONTEXTS_INCLUDES_IN_CLUSTERis not set,in-clusteris includedSKYPILOT_ALL_KUBERNETES_CONTEXTS_INCLUDES_IN_CLUSTERset to false,in-clusteris not includedSKYPILOT_ALL_KUBERNETES_CONTEXTS_INCLUDES_IN_CLUSTERset to true,in-clusteris included/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)