Skip to content

fix: use node 22 #4081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramonpetgrave64 merged 6 commits into from
Jan 28, 2025
Merged

fix: use node 22 #4081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
740166e
use node 20
ramonpetgrave64 Jan 27, 2025
3134651
fix: update pre-submit to ubuntu24 (#4080)
ramonpetgrave64 Jan 28, 2025
61917d6
use node 20
ramonpetgrave64 Jan 28, 2025
300e919
Merge branch 'main' into ramonpetgrave64-patch-4
ramonpetgrave64 Jan 28, 2025
7a130e0
Merge branch 'main' into ramonpetgrave64-patch-4
ramonpetgrave64 Jan 28, 2025
a60453e
use node 22
ramonpetgrave64 Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e.sign-attestations.schedule.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a # v4
with:
node-version: 20
node-version: 22
- name: install sigstore-js
run: npm ci
# TODO: Add subject verification. This only verifies the signature on the DSSE envelope.
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/pre-submit.actions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,10 @@ jobs:
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

- name: Set Node.js 18
- name: Set Node.js 22
uses: actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a # v4.2.0
with:
node-version: 18
node-version: 22

- name: Rebuild the dist/ directory
working-directory: ${{ matrix.action }}
Expand Down Expand Up @@ -197,7 +197,7 @@ jobs:
uses: ./__BUILDER_CHECKOUT_DIR__/.github/actions/secure-project-checkout-node
with:
path: __PROJECT_CHECKOUT_DIR__
node-version: 16
node-version: 22

secure-upload-folder:
runs-on: ubuntu-latest
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/pre-submit.lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
go-version: "1.22.3"
- uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v3.8.2
with:
node-version: 20
node-version: 22

- name: Install gofumpt
run: go install mvdan.cc/gofumpt@v0.6.0
Expand Down Expand Up @@ -76,7 +76,7 @@ jobs:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- uses: actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a # v4.2.0
with:
node-version: 20
node-version: 22
- run: make markdownlint

golangci-lint:
Expand Down Expand Up @@ -162,7 +162,7 @@ jobs:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- uses: actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a # v4.2.0
with:
node-version: 20
node-version: 22
- run: make eslint

renovate-config-validator:
Expand All @@ -171,5 +171,5 @@ jobs:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- uses: actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a # v4.2.0
with:
node-version: 20
node-version: 22
- run: make renovate-config-validator
4 changes: 2 additions & 2 deletions .github/workflows/pre-submit.units.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ jobs:
with:
go-version-file: "go.mod"

- name: Set Node.js 16
- name: Set Node.js 22
uses: actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a # v4.2.0
with:
node-version: 16
node-version: 22

- name: unit tests
run: |
Expand Down