Skip to content

Fix Telemetry Flag Capture and Workflow Language Attribution#522

Merged
ejacquier merged 2 commits into
mainfrom
DEVSVCS-5147/telemetry-flag-fix
Jul 8, 2026
Merged

Fix Telemetry Flag Capture and Workflow Language Attribution#522
ejacquier merged 2 commits into
mainfrom
DEVSVCS-5147/telemetry-flag-fix

Conversation

@ejacquier

Copy link
Copy Markdown
Contributor

Problem

Telemetry was capturing command output, error messages, and HTTP payloads as flag values, and workflow_language was missing from some command events (especially failures).

Solution

Flag Sanitization (core fix)

  • Added garbage detection: New looksLikeUnintendedContent() redacts any flag value that doesn't look like a real CLI argument — catches >256 char values, newlines, JSON blobs ({/[), and output signatures (panic:, traceback, goroutine, HTTP/1.x, "error", <html).
  • Closed flag-name gaps: Added changeset-file to full-redact list, project-root to path-redact (basename only).
  • Backstop on args: Same guard applied to positional arguments for defense-in-depth.

Workflow Language Attachment

  • convert command: Now captures detected workflow language (was computing it but discarding).
  • deploy & simulate: Moved WASM language assignment earlier — now fires as soon as WASM path is known, before read/fetch/compile operations that can fail. Ensures language is recorded even on failure.

@ejacquier ejacquier requested a review from a team as a code owner July 8, 2026 16:05
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

👋 ejacquier, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@ejacquier ejacquier enabled auto-merge July 8, 2026 17:49
@ejacquier ejacquier added this pull request to the merge queue Jul 8, 2026
Merged via the queue into main with commit 9bdea7d Jul 8, 2026
22 checks passed
@ejacquier ejacquier deleted the DEVSVCS-5147/telemetry-flag-fix branch July 8, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants