Skip to content

updated storage inmemory telemetry #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chillaq merged 1 commit into from
Aug 23, 2023
Merged

updated storage inmemory telemetry #448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions splitio/storage/inmemmory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,6 +499,10 @@ def record_ready_time(self, ready_time):
"""Record ready time."""
self._tel_config.record_ready_time(ready_time)

def record_flag_sets(self, flag_sets):
"""Record flag sets."""
self._tel_config.record_flag_sets(flag_sets)

def add_tag(self, tag):
"""Record tag string."""
with self._lock:
Expand Down Expand Up @@ -567,6 +571,10 @@ def record_update_from_sse(self, event):
"""Record update from sse."""
self._counters.record_update_from_sse(event)

def get_flag_sets(self):
"""Get flag sets."""
self._tel_config.get_flag_sets()

def get_bur_time_outs(self):
"""Get block until ready timeout."""
return self._tel_config.get_bur_time_outs()
Expand Down
7 changes: 5 additions & 2 deletions tests/storage/test_inmemory_storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,8 @@ def test_resets(self):
'iL': False,
'hp': None,
'aF': 0,
'rF': 0
'rF': 0,
'fS': 0
})
assert(storage._streaming_events.pop_streaming_events() == {'streamingEvents': []})
assert(storage._tags == [])
Expand All @@ -492,6 +493,7 @@ def test_record_config(self):
}
storage.record_config(config, {})
storage.record_active_and_redundant_factories(1, 0)
storage.record_flag_sets(2)
assert(storage._tel_config.get_stats() == {'oM': 0,
'sT': storage._tel_config._get_storage_type(config['operationMode'], config['storageType']),
'sE': config['streamingEnabled'],
Expand All @@ -506,7 +508,8 @@ def test_record_config(self):
'tR': 0,
'nR': 0,
'aF': 1,
'rF': 0}
'rF': 0,
'fS': 2}
)

def test_record_counters(self):
Expand Down