Skip to content

updated engine.telemetry class #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chillaq merged 2 commits into from
Aug 28, 2023
Merged

updated engine.telemetry class #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
587cbe1
updated engine.telemetry class
chillaq Aug 24, 2023
89788f5
Update tests/engine/test_telemetry.py
chillaq Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions splitio/engine/telemetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@ def record_ready_time(self, ready_time):
"""Record ready time."""
self._telemetry_storage.record_ready_time(ready_time)

def record_flag_sets(self, flag_sets):
"""Record flag sets."""
self._telemetry_storage.record_flag_sets(flag_sets)

def record_bur_time_out(self):
"""Record block until ready timeout."""
self._telemetry_storage.record_bur_time_out()
Expand Down
43 changes: 35 additions & 8 deletions tests/engine/test_telemetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,42 @@ def test_instances(self):
assert(telemetry_producer._telemetry_runtime_producer == telemetry_producer.get_telemetry_runtime_producer())

def test_record_config(self, mocker):
telemetry_storage = mocker.Mock()
telemetry_storage = InMemoryTelemetryStorage()
telemetry_init_producer = TelemetryInitProducer(telemetry_storage)

def record_config(*args, **kwargs):
self.passed_config = args[0]

telemetry_storage.record_config.side_effect = record_config
telemetry_init_producer.record_config({'bT':0, 'nR':0, 'uC': 0}, {})
assert(self.passed_config == {'bT':0, 'nR':0, 'uC': 0})
config = {'operationMode': 'standalone',
'streamingEnabled': True,
'impressionsQueueSize': 100,
'eventsQueueSize': 200,
'impressionsMode': 'DEBUG',
'impressionListener': None,
'featuresRefreshRate': 30,
'segmentsRefreshRate': 30,
'impressionsRefreshRate': 60,
'eventsPushRate': 60,
'metricsRefreshRate': 10,
'storageType': None
}
telemetry_init_producer.record_config(config, {})
telemetry_init_producer.record_active_and_redundant_factories(1, 0)
telemetry_init_producer.record_flag_sets(2)

assert(telemetry_storage._tel_config.get_stats() == {'oM': 0,
'sT': telemetry_storage._tel_config._get_storage_type(config['operationMode'], config['storageType']),
'sE': config['streamingEnabled'],
'rR': {'sp': 30, 'se': 30, 'im': 60, 'ev': 60, 'te': 10},
'uO': {'s': False, 'e': False, 'a': False, 'st': False, 't': False},
'iQ': config['impressionsQueueSize'],
'eQ': config['eventsQueueSize'],
'iM': telemetry_storage._tel_config._get_impressions_mode(config['impressionsMode']),
'iL': True if config['impressionListener'] is not None else False,
'hp': telemetry_storage._tel_config._check_if_proxy_detected(),
'bT': 0,
'tR': 0,
'nR': 0,
'aF': 1,
'rF': 0,
'fS': 2}
)

def test_record_ready_time(self, mocker):
telemetry_storage = mocker.Mock()
Expand Down