Skip to content

Sniffer messages cleaner#1341

Merged
plebhash merged 3 commits into
stratum-mining:mainfrom
jbesraa:2025-01-09-sniffer-clear-fn
Jan 17, 2025
Merged

Sniffer messages cleaner#1341
plebhash merged 3 commits into
stratum-mining:mainfrom
jbesraa:2025-01-09-sniffer-clear-fn

Conversation

@jbesraa

@jbesraa jbesraa commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

resolves #1336

@github-actions

github-actions Bot commented Jan 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

🐰 Bencher Report

Branch2025-01-09-sniffer-clear-fn
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client-submit-serialize📈 view plot
🚷 view threshold		6,457.00
(-1.42%)		6,938.62
(93.06%)
client-submit-serialize-deserialize📈 view plot
🚷 view threshold		7,240.90
(-2.11%)		7,851.10
(92.23%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle📈 view plot
🚷 view threshold		7,881.90
(-2.57%)		9,426.58
(83.61%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle📈 view plot
🚷 view threshold		883.61
(+1.68%)		944.89
(93.51%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize📈 view plot
🚷 view threshold		675.76
(-0.06%)		724.66
(93.25%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize📈 view plot
🚷 view threshold		248.54
(-0.63%)		274.16
(90.66%)
client-sv1-get-authorize/client-sv1-get-authorize📈 view plot
🚷 view threshold		156.49
(-0.64%)		165.34
(94.64%)
client-sv1-get-submit📈 view plot
🚷 view threshold		6,223.30
(-1.78%)		6,767.34
(91.96%)
client-sv1-get-subscribe/client-sv1-get-subscribe📈 view plot
🚷 view threshold		278.82
(-1.79%)		337.95
(82.50%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle📈 view plot
🚷 view threshold		722.31
(-0.69%)		779.85
(92.62%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize📈 view plot
🚷 view threshold		594.90
(+0.75%)		627.83
(94.75%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize📈 view plot
🚷 view threshold		203.61
(-1.34%)		226.70
(89.81%)
🐰 View full continuous benchmarking report in Bencher

@github-actions

github-actions Bot commented Jan 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

🐰 Bencher Report

Branch2025-01-09-sniffer-clear-fn
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		45.19
(-0.22%)		60.02
(75.30%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		74.66
(-3.50%)		107.56
(69.41%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		14.73
(+0.43%)		14.75
(99.87%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		273.02
(+3.48%)		286.64
(95.25%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		642.15
(+3.81%)		685.75
(93.64%)
client_sv2_open_channel📈 view plot
🚷 view threshold		163.03
(-1.73%)		179.49
(90.83%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		296.18
(+3.24%)		316.25
(93.66%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		381.26
(-0.26%)		399.01
(95.55%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		162.57
(+1.58%)		171.56
(94.76%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		452.67
(-3.53%)		556.74
(81.31%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		983.69
(-2.52%)		1,224.32
(80.35%)
🐰 View full continuous benchmarking report in Bencher

@github-actions

github-actions Bot commented Jan 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

🐰 Bencher Report

Branch2025-01-09-sniffer-clear-fn
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
1e3 x estimated cycles
(Result Δ%)		Upper Boundary
1e3 x estimated cycles
(Limit %)		InstructionsBenchmark Result
1e3 x instructions
(Result Δ%)		Upper Boundary
1e3 x instructions
(Limit %)		L1 AccessesBenchmark Result
1e3 x accesses
(Result Δ%)		Upper Boundary
1e3 x accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
get_authorize📈 view plot
🚷 view threshold		8.41
(-0.57%)		8.67
(96.93%)		📈 view plot
🚷 view threshold		3.66
(-1.63%)		3.86
(94.85%)		📈 view plot
🚷 view threshold		5.11
(-1.93%)		5.45
(93.82%)		📈 view plot
🚷 view threshold		8.00
(-6.06%)		16.41
(48.74%)		📈 view plot
🚷 view threshold		93.00
(+1.72%)		96.85
(96.03%)
get_submit📈 view plot
🚷 view threshold		95.35
(-0.01%)		95.61
(99.73%)		📈 view plot
🚷 view threshold		59.26
(-0.23%)		59.71
(99.25%)		📈 view plot
🚷 view threshold		85.08
(-0.27%)		85.82
(99.13%)		📈 view plot
🚷 view threshold		46.00
(+2.61%)		60.36
(76.21%)		📈 view plot
🚷 view threshold		287.00
(+2.20%)		292.06
(98.27%)
get_subscribe📈 view plot
🚷 view threshold		7.93
(-0.78%)		8.23
(96.38%)		📈 view plot
🚷 view threshold		2.76
(-1.89%)		2.94
(93.73%)		📈 view plot
🚷 view threshold		3.83
(-2.30%)		4.14
(92.48%)		📈 view plot
🚷 view threshold		15.00
(+19.33%)		20.78
(72.17%)		📈 view plot
🚷 view threshold		115.00
(+0.40%)		117.93
(97.52%)
serialize_authorize📈 view plot
🚷 view threshold		12.19
(-0.54%)		12.50
(97.50%)		📈 view plot
🚷 view threshold		5.24
(-1.08%)		5.43
(96.56%)		📈 view plot
🚷 view threshold		7.28
(-1.30%)		7.60
(95.77%)		📈 view plot
🚷 view threshold		9.00
(-12.33%)		18.89
(47.63%)		📈 view plot
🚷 view threshold		139.00
(+0.74%)		143.32
(96.99%)
serialize_deserialize_authorize📈 view plot
🚷 view threshold		24.69
(-0.11%)		25.19
(98.02%)		📈 view plot
🚷 view threshold		9.79
(-0.71%)		10.01
(97.75%)		📈 view plot
🚷 view threshold		13.79
(-0.85%)		14.18
(97.26%)		📈 view plot
🚷 view threshold		31.00
(-13.68%)		45.97
(67.43%)		📈 view plot
🚷 view threshold		307.00
(+1.10%)		313.74
(97.85%)
serialize_deserialize_handle_authorize📈 view plot
🚷 view threshold		30.27
(-0.16%)		30.72
(98.54%)		📈 view plot
🚷 view threshold		11.99
(-0.50%)		12.19
(98.38%)		📈 view plot
🚷 view threshold		16.95
(-0.60%)		17.30
(98.03%)		📈 view plot
🚷 view threshold		53.00
(-5.07%)		67.44
(78.58%)		📈 view plot
🚷 view threshold		373.00
(+0.52%)		379.44
(98.30%)
serialize_deserialize_handle_submit📈 view plot
🚷 view threshold		126.56
(+0.09%)		126.78
(99.83%)		📈 view plot
🚷 view threshold		73.12
(-0.18%)		73.54
(99.43%)		📈 view plot
🚷 view threshold		104.76
(-0.22%)		105.51
(99.29%)		📈 view plot
🚷 view threshold		112.00
(+4.88%)		125.95
(88.92%)		📈 view plot
🚷 view threshold		607.00
(+1.52%)		610.93
(99.36%)
serialize_deserialize_handle_subscribe📈 view plot
🚷 view threshold		27.89
(-0.08%)		28.38
(98.26%)		📈 view plot
🚷 view threshold		9.58
(-0.55%)		9.76
(98.13%)		📈 view plot
🚷 view threshold		13.52
(-0.69%)		13.84
(97.70%)		📈 view plot
🚷 view threshold		67.00
(+3.73%)		78.01
(85.88%)		📈 view plot
🚷 view threshold		401.00
(+0.43%)		409.79
(97.86%)
serialize_deserialize_submit📈 view plot
🚷 view threshold		115.30
(+0.05%)		115.72
(99.64%)		📈 view plot
🚷 view threshold		67.89
(-0.24%)		68.42
(99.23%)		📈 view plot
🚷 view threshold		97.36
(-0.29%)		98.30
(99.04%)		📈 view plot
🚷 view threshold		68.00
(+3.58%)		87.77
(77.47%)		📈 view plot
🚷 view threshold		503.00
(+1.91%)		505.70
(99.47%)
serialize_deserialize_subscribe📈 view plot
🚷 view threshold		23.30
(-0.09%)		23.82
(97.84%)		📈 view plot
🚷 view threshold		8.13
(-0.68%)		8.32
(97.75%)		📈 view plot
🚷 view threshold		11.42
(-0.83%)		11.75
(97.25%)		📈 view plot
🚷 view threshold		38.00
(-2.64%)		51.12
(74.34%)		📈 view plot
🚷 view threshold		334.00
(+0.69%)		342.49
(97.52%)
serialize_submit📈 view plot
🚷 view threshold		99.80
(+0.01%)		100.09
(99.71%)		📈 view plot
🚷 view threshold		61.33
(-0.21%)		61.74
(99.33%)		📈 view plot
🚷 view threshold		87.93
(-0.25%)		88.65
(99.19%)		📈 view plot
🚷 view threshold		49.00
(+1.60%)		67.05
(73.08%)		📈 view plot
🚷 view threshold		332.00
(+2.00%)		337.80
(98.28%)
serialize_subscribe📈 view plot
🚷 view threshold		11.41
(+0.09%)		11.60
(98.38%)		📈 view plot
🚷 view threshold		4.11
(-1.19%)		4.28
(95.99%)		📈 view plot
🚷 view threshold		5.69
(-1.54%)		6.00
(94.88%)		📈 view plot
🚷 view threshold		17.00
(+21.36%)		24.36
(69.79%)		📈 view plot
🚷 view threshold		161.00
(+1.53%)		164.69
(97.76%)
🐰 View full continuous benchmarking report in Bencher

@github-actions

github-actions Bot commented Jan 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

🐰 Bencher Report

Branch2025-01-09-sniffer-clear-fn
Testbedsv2

🚨 1 Alert

BenchmarkMeasure
Units		ViewBenchmark Result
(Result Δ%)		Upper Boundary
(Limit %)
client_sv2_open_channel_serializeL2 Accesses
accesses		📈 plot
🚨 alert (🔔)
🚷 threshold		51.00
(+38.69%)		49.12
(103.83%)
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
1e3 x estimated cycles
(Result Δ%)		Upper Boundary
1e3 x estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		2.20
(+4.04%)		2.24
(98.25%)		📈 view plot
🚷 view threshold		473.00
(-0.13%)		490.59
(96.41%)		📈 view plot
🚷 view threshold		731.00
(-0.67%)		758.99
(96.31%)		📈 view plot
🚷 view threshold		7.00
(+37.42%)		11.63
(60.20%)		📈 view plot
🚷 view threshold		41.00
(+5.98%)		41.81
(98.06%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		8.28
(+0.60%)		8.40
(98.52%)		📈 view plot
🚷 view threshold		2,137.00📈 view plot
🚷 view threshold		3,156.00
(-0.09%)		3,167.39
(99.64%)		📈 view plot
🚷 view threshold		37.00
(+3.97%)		41.52
(89.11%)		📈 view plot
🚷 view threshold		141.00
(+0.92%)		144.56
(97.53%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		6.35
(+0.80%)		6.45
(98.50%)		📈 view plot
🚷 view threshold		1,750.00
(-0.03%)		1,767.59
(99.00%)		📈 view plot
🚷 view threshold		2,548.00
(-0.15%)		2,575.46
(98.93%)		📈 view plot
🚷 view threshold		19.00
(+10.75%)		24.05
(79.00%)		📈 view plot
🚷 view threshold		106.00
(+1.22%)		108.80
(97.43%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		14.80
(+0.51%)		14.94
(99.09%)		📈 view plot
🚷 view threshold		4,694.00
(-0.01%)		4,711.59
(99.63%)		📈 view plot
🚷 view threshold		6,742.00
(-0.20%)		6,786.80
(99.34%)		📈 view plot
🚷 view threshold		58.00
(+26.50%)		63.55
(91.27%)		📈 view plot
🚷 view threshold		222.00
(+0.37%)		226.14
(98.17%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		27.84
(+0.86%)		28.07
(99.20%)		📈 view plot
🚷 view threshold		10,645.00
(+0.35%)		10,699.43
(99.49%)		📈 view plot
🚷 view threshold		15,497.00
(+0.36%)		15,595.18
(99.37%)		📈 view plot
🚷 view threshold		96.00
(+14.47%)		99.53
(96.45%)		📈 view plot
🚷 view threshold		339.00
(+1.02%)		343.25
(98.76%)
client_sv2_open_channel📈 view plot
🚷 view threshold		4.49
(+2.02%)		4.59
(97.99%)		📈 view plot
🚷 view threshold		1,461.00
(-0.04%)		1,478.59
(98.81%)		📈 view plot
🚷 view threshold		2,153.00
(-0.35%)		2,184.78
(98.55%)		📈 view plot
🚷 view threshold		13.00
(+58.02%)		14.13
(91.98%)		📈 view plot
🚷 view threshold		65.00
(+3.29%)		67.83
(95.83%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		14.11
(+0.64%)		14.20
(99.34%)		📈 view plot
🚷 view threshold		5,064.00
(-0.01%)		5,081.59
(99.65%)		📈 view plot
🚷 view threshold		7,310.00
(-0.22%)		7,353.00
(99.42%)		📈 view plot
🚨 view alert (🔔)
🚷 view threshold		51.00
(+38.69%)		49.12
(103.83%)		📈 view plot
🚷 view threshold		187.00
(+0.52%)		190.91
(97.95%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		22.87
(+0.72%)		23.08
(99.13%)		📈 view plot
🚷 view threshold		8,040.00
(+0.09%)		8,057.64
(99.78%)		📈 view plot
🚷 view threshold		11,684.00
(-0.01%)		11,713.47
(99.75%)		📈 view plot
🚷 view threshold		89.00
(+17.25%)		90.35
(98.51%)		📈 view plot
🚷 view threshold		307.00
(+0.93%)		312.87
(98.12%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		4.75
(+1.20%)		4.79
(99.08%)		📈 view plot
🚷 view threshold		1,502.00
(-0.04%)		1,519.59
(98.84%)		📈 view plot
🚷 view threshold		2,274.00
(-0.21%)		2,300.99
(98.83%)		📈 view plot
🚷 view threshold		12.00
(+27.15%)		15.31
(78.37%)		📈 view plot
🚷 view threshold		69.00
(+2.05%)		70.18
(98.32%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		16.31
(+0.94%)		16.33
(99.86%)		📈 view plot
🚷 view threshold		5,963.00
(-0.01%)		5,980.59
(99.71%)		📈 view plot
🚷 view threshold		8,645.00
(-0.22%)		8,692.92
(99.45%)		📈 view plot
🚷 view threshold		56.00
(+37.27%)		56.87
(98.47%)		📈 view plot
🚷 view threshold		211.00
(+1.30%)		212.26
(99.41%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		35.87
(+0.73%)		35.96
(99.73%)		📈 view plot
🚷 view threshold		14,888.00
(+0.14%)		14,919.71
(99.79%)		📈 view plot
🚷 view threshold		21,861.00
(+0.08%)		21,918.93
(99.74%)		📈 view plot
🚷 view threshold		113.00
(+19.35%)		120.34
(93.90%)		📈 view plot
🚷 view threshold		384.00
(+1.14%)		385.89
(99.51%)
🐰 View full continuous benchmarking report in Bencher

@codecov

codecov Bot commented Jan 9, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.11%. Comparing base (568f7df) to head (1f6da7d).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1341   +/-   ##
=======================================
  Coverage   19.11%   19.11%           
=======================================
  Files         166      166           
  Lines       11047    11047           
=======================================
  Hits         2112     2112           
  Misses       8935     8935
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.56% <ø> (ø)
binary_sv2-coverage 5.36% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.13% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.28% <ø> (ø)
jd_client-coverage 0.00% <ø> (ø)
jd_server-coverage 7.79% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.45% <ø> (ø)
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.70% <ø> (ø)
noise_sv2-coverage 4.46% <ø> (ø)
pool_sv2-coverage 2.05% <ø> (ø)
protocols 24.63% <ø> (ø)
roles 6.55% <ø> (ø)
roles_logic_sv2-coverage 7.95% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.60% <ø> (ø)
utils 25.13% <ø> (ø)
v1-coverage 2.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbesraa jbesraa marked this pull request as ready for review January 10, 2025 11:31
jbesraa
jbesraa commented Jan 10, 2025
View reviewed changes
Comment thread roles/tests-integration/tests/pool_integration.rs
&pool_translator_sniffer.next_message_from_upstream(),
SetNewPrevHash
);
pool_translator_sniffer

@jbesraa jbesraa Jan 10, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GitGab19

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

@plebhash plebhash requested a review from GitGab19 January 14, 2025 17:31
GitGab19
GitGab19 reviewed Jan 16, 2025
View reviewed changes
Comment thread roles/tests-integration/lib/sniffer.rs Outdated
GitGab19
GitGab19 reviewed Jan 16, 2025
View reviewed changes
Comment thread roles/tests-integration/lib/sniffer.rs Outdated
@GitGab19

GitGab19 commented Jan 16, 2025

Copy link
Copy Markdown
Member

Can you fix fmt errors?

@plebhash plebhash added the ready-to-be-merged triggers auto rebase bot label Jan 17, 2025
@plebhash plebhash merged commit 4190257 into stratum-mining:main Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitGab19 GitGab19 GitGab19 approved these changes
@plebhash plebhash plebhash approved these changes

Assignees

No one assigned

Labels

integration-tests ready-to-be-merged triggers auto rebase bot

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

need new method Sniffer::has_message_type_with_remove

3 participants

@jbesraa @GitGab19 @plebhash