Add MockDownstream#1671
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1671 +/- ##
=======================================
Coverage 21.20% 21.20%
=======================================
Files 134 134
Lines 10000 10000
=======================================
Hits 2120 2120
Misses 7880 7880
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
This is ready for review |
Member
|
An integration test is failing: https://github.com/stratum-mining/stratum/actions/runs/15040627485/job/42271266170?pr=1671 It's the "usual" It would be good to fix it since I noticed it's randomly failing on many PRs. |
Shourya742
reviewed
May 15, 2025
Shourya742
left a comment
Member
There was a problem hiding this comment.
Changes looks cleans to me. Surprisingly I am facing this issue running the test locally.
Failed to start bitcoind due to Error while executing "/home/stratum/test/integration-tests/template-provider/bitcoin-sv2-tp-0.1.15/bin/bitcoind"
Failed to start bitcoind due to Error while executing "/home/stratum/test/integration-tests/template-provider/bitcoin-sv2-tp-0.1.15/bin/bitcoind"
Failed to start bitcoind due to Error while executing "/home/stratum/test/integration-tests/template-provider/bitcoin-sv2-tp-0.1.15/bin/bitcoind"
Failed to start bitcoind due to Error while executing "/home/stratum/test/integration-tests/template-provider/bitcoin-sv2-tp-0.1.15/bin/bitcoind"
Failed to start bitcoind due to Error while executing "/home/stratum/test/integration-tests/template-provider/bitcoin-sv2-tp-0.1.15/bin/bitcoind".. to `integration-tests` This module can act as a downstream role. It can send and receive messages from an upstream role.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by #1662Partially resolves #1670