Skip to content

fix: do not iterate over prototype properties of reducers #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich-Harris merged 4 commits into from
Sep 25, 2024
Merged

fix: do not iterate over prototype properties of reducers #80

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8b90bd7
fix: do not iterate over prototype properties of reduers
danielroe Aug 30, 2024
012f36d
Merge remote-tracking branch 'upstream/main' into fix/proto
danielroe Sep 25, 2024
e3ab1dd
fix: guard null/empty reducers
danielroe Sep 25, 2024
77fa57b
add test
Rich-Harris Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: guard null/empty reducers
  • Loading branch information
@danielroe
danielroe committed Sep 25, 2024
commit e3ab1dd526c42473f87643fde247f38372666c07
6 changes: 4 additions & 2 deletions src/stringify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,10 @@ export function stringify(value, reducers) {

/** @type {Array<{ key: string, fn: (value: any) => any }>} */
const custom = [];
for (const key of Object.getOwnPropertyNames(reducers)) {
custom.push({ key, fn: reducers[key] });
if (reducers) {
for (const key of Object.getOwnPropertyNames(reducers)) {
custom.push({ key, fn: reducers[key] });
}
}

/** @type {string[]} */
Expand Down