Fix/prefix ids sameline comments#1942
Merged
SethFalco merged 3 commits intoJan 23, 2024
Merged
Conversation
Before, this worked:
<style>
.cls-1 {}
<!-- foo -->
.cls-2 {}
</style>
but this failed:
<style>
.cls-1 {} <!-- foo -->
.cls-2 {}
</style>
.cls-1 would be prefixed, but .cls-2 and subsquent classes would not.
The root cause is an empty return that was missed during a refactor to
switch from forEach() with a lambda to a for () loop.
Add a new test to cover this case.
KTibow
reviewed
Jan 22, 2024
Co-authored-by: Seth Falco <seth@falco.fun>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1941
Fix prefixing classes on same line as a comment
Before, this worked:
but this failed:
.cls-1 would be prefixed, but .cls-2 and subsquent classes would not.
The root cause is an empty return that was missed during a refactor to
switch from forEach() with a lambda to a for () loop.
Add a new test to cover this case.