Test highlighting of prettyDOM explicitly#1324
Merged
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 67dee41:
|
eps1lon
commented
Jul 5, 2024
| import {configure, getConfig} from '../config' | ||
| import {render, renderIntoDocument} from './helpers/test-utils' | ||
|
|
||
| expect.addSnapshotSerializer(jestSnapshotSerializerAnsi) |
Member
Author
There was a problem hiding this comment.
DRY tests are not desired. This helps noticing when tests ignore color coding.
eps1lon
commented
Jul 5, 2024
They hide console logs which we shouldn't do for pretty-dom since that shouldn't console.log in the first place
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous test setup hid legit bugs (e.g. #1322). Now we test
prettyDOMin each environment (Browser and browser-ish (node+jsdom) on the exact colors by not stripping the ANSI color codes anymore.