Skip to content

Update CI/CD and readme#34

Merged
1NFR4R3D merged 9 commits into
mainfrom
update-ci-and-readme
May 11, 2026
Merged

Update CI/CD and readme#34
1NFR4R3D merged 9 commits into
mainfrom
update-ci-and-readme

Conversation

@1NFR4R3D

@1NFR4R3D 1NFR4R3D commented May 8, 2026

Copy link
Copy Markdown
Collaborator

Readme list changes:

  • Clarified that target controls are disabled by default
  • Mark "New Scenes" repair flow as done
  • Move "Deleted Scenes" to its own task, and marked done
  • Removed Target repair flows (since there is nothing to do there, will be handled directly)
  • Removed Scene deduplication. Due to differences in how Scenes are handled by Tewke and entities are assigned to devices in HA, a better solution for the time being is implemented: allow users to disable Scenes during setup.)

Part of ENG-1922

Summary by CodeRabbit

  • Documentation

    • Updated README feature list: refined repair-flow items, clarified Target control default (disabled), and adjusted visible feature statuses.
    • Removed the user-facing description for the "New Scenes discovered" issue (title and fix flow remain).
  • Chores

    • Added automated validation workflows to run on pushes, pull requests, daily schedule, and manual dispatch.
  • Other

    • Added an issue tracker URL to the integration manifest.

1NFR4R3D added 2 commits May 8, 2026 14:38
- Clarified that target controls are disabled by default
- Mark "New Scenes" repair flow as done
- Move "Deleted Scenes" to its own task, and marked done
- Removed Target repair flows (since there is nothing to do there, will be handled directly)
- Removed Scene deduplication. Due to differences in how Scenes are handled by Tewke and entities are assigned to devices in HA, a better solution for the time being is implemented: allow users to disable Scenes during setup.)
@1NFR4R3D 1NFR4R3D self-assigned this May 8, 2026
@coderabbitai

coderabbitai Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Rate limit exceeded

@1NFR4R3D has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 16 minutes and 20 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 441e09de-1771-471d-a5e6-7a010b7744ce

📥 Commits

Reviewing files that changed from the base of the PR and between a803911 and 931e918.

📒 Files selected for processing (3)
  • .github/workflows/hacs.yml
  • .github/workflows/hassfest.yml
  • README.md
📝 Walkthrough

Walkthrough

Adds two validation workflows (HACS and hassfest), updates README feature entries and badge formatting, adds an issue_tracker to the tewke manifest, and removes the "new scenes" description from localization files.

Changes

CI Workflows

Layer / File(s) Summary
HACS Workflow: Triggers & Permissions
.github/workflows/hacs.yml
Workflow named "Validate HACS" with triggers: push, pull_request, daily cron, workflow_dispatch; workflow permissions set to an empty object.
HACS Workflow: Job Execution
.github/workflows/hacs.yml
Job validate-hacs on ubuntu-latest executes hacs/action@main with category: integration.
hassfest Workflow
.github/workflows/hassfest.yml
Adds "Validate with hassfest" workflow triggering on push, pull_request, daily cron; job validate checks out repo and runs hassfest on ubuntu-latest.

README Documentation Update

Layer / File(s) Summary
Badge Section
README.md
Top-of-file badge formatting adjusted to include an explicit trailing space.
Feature List Refinement
README.md
Feature list updated: adds "Target control (default disabled)", retains "Sensor data", narrows "Repair flows" to "New Scenes" (enabled) and "Rename Scenes" (disabled), enables "Handle deleted Scenes" and "Reconfigure flow"; removes prior broader repair-flow items.

Integration Manifest & Localization

Layer / File(s) Summary
Manifest Update
custom_components/tewke/manifest.json
Inserted issue_tracker field and adjusted field ordering/formatting; version remains 0.1.0, requirements and zeroconf unchanged.
Localization Strings
custom_components/tewke/strings.json, custom_components/tewke/translations/en.json
Removed the description for issues.new_scenes_found, leaving the title intact in both files.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • oskarwilliams

Poem

🐰 A tiny patch hops through CI light,
Two workflows hum and badges sit right,
Manifest whispers where issues should go,
Strings tidy up so the messages flow,
Hoppy checks run, and the docs shine bright.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The PR title 'Update CI/CD and readme' aligns with the main changes: adding CI/CD workflows (hassfest, HACS validation) and updating the README feature list.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update-ci-and-readme

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/hassfest.yml:
- Line 14: The workflow currently uses a mutable reference "uses:
home-assistant/actions/hassfest@master"; replace this moving branch with a fixed
release tag or commit SHA (for example a specific version like `@vX.Y.Z` or a full
commit SHA) so the hassfest action is pinned and CI is reproducible and secure;
update the "uses: home-assistant/actions/hassfest@master" occurrence to the
chosen immutable tag/SHA.
- Line 13: The workflow currently pins the checkout action to
actions/checkout@v3 which uses Node 16; update the GitHub Actions step that
references "uses: \"actions/checkout@v3\"" to "uses: \"actions/checkout@v4\"" so
the job uses the supported major version (Node 20) and will run on current
GitHub-hosted runners.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0c8e93c5-237a-440b-9710-65b9c0bf3f5e

📥 Commits

Reviewing files that changed from the base of the PR and between c3b74e7 and a803911.

📒 Files selected for processing (4)
  • .github/workflows/hassfest.yml
  • custom_components/tewke/manifest.json
  • custom_components/tewke/strings.json
  • custom_components/tewke/translations/en.json
💤 Files with no reviewable changes (2)
  • custom_components/tewke/translations/en.json
  • custom_components/tewke/strings.json
✅ Files skipped from review due to trivial changes (1)
  • custom_components/tewke/manifest.json

Comment thread .github/workflows/hassfest.yml Outdated
Comment thread .github/workflows/hassfest.yml Outdated
@1NFR4R3D 1NFR4R3D enabled auto-merge May 8, 2026 18:37
@1NFR4R3D 1NFR4R3D added this pull request to the merge queue May 11, 2026
Merged via the queue into main with commit 87ac35e May 11, 2026
5 checks passed
@1NFR4R3D 1NFR4R3D deleted the update-ci-and-readme branch May 11, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants