feat(tracing-appender): add the ability for RollingFileAppender to use the local time#3525
Open
jschillem wants to merge 1 commit into
Open
feat(tracing-appender): add the ability for RollingFileAppender to use the local time#3525jschillem wants to merge 1 commit into
RollingFileAppender to use the local time#3525jschillem wants to merge 1 commit into
Conversation
b30dfb8 to
2c01e1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3524, allowing the
RollingFileAppendertimezone to be configurable.Motivation
There may be use cases (like in the linked issue) where a user would want all of their logs to be framed within their local time zone instead of UTC. Currently, the
RollingFileAppenderalways uses UTC for rolling files.Solution
local-timefeature flag totracing-appenderto match the opt-in format used bytracing-subscriber.ClockKindenum for configuration.rolling::Builderwith ause_local_time()anduse_utc()method (by default it will use UTC formatting).ClockKind::Local.This feature has no breaking changes and is strictly opt-in due to
ClockKindimplementing UTC as its default variant.