subscriber: Change Writer's with_ansi* accessors to pub#3554
Open
bminortx wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the scope of the
with_ansi*accessors in theWriterclass frompub(crate)topub.Motivation
Our software's workflow maps a subscriber's events to a
Writerclass for writing stdout and stderr to an HTML file. While the subscriber layer itself can setwith_ansi_sanitizationto false (thereby giving us "clean" output), the writer instead holds its own state. This caused some confusion when theWriterended up writing codes, when the output to the console did not.Solution
Make the accessors public so that we can modify the
Writerbehavior to match the layer from which it is mapped. Happy to hear other solutions, but given the discussion in the file, it seems like this may have been on your minds anyway.