fix: point appender symlink to correct target#3573
Open
aurelj wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest_symlink feature added to tracing-appender is creating a symlink pointing to an invalid target.
Here is a simple example that shows the issue:
and here is the resulting symlink:
$ cargo run $ ls -l logs lrwxrwxrwx 1 aurel aurel 25 30 juin 18:22 myapp.log -> logs/myapp.log.2026-06-30 -rw-rw-r-- 1 aurel aurel 0 30 juin 18:22 myapp.log.2026-06-30Note that both the log file and the symlink are inside the
logsdirectory but the symlink is pointing tologs/myapp.log.2026-06-30instead ofmyapp.log.2026-06-30.This patch fixes the issue and generate the proper symlink as shown here:
$ cargo run $ ls -l logs lrwxrwxrwx 1 aurel aurel 20 30 juin 18:24 myapp.log -> myapp.log.2026-06-30 -rw-rw-r-- 1 aurel aurel 0 30 juin 18:24 myapp.log.2026-06-30