appender: introduce monthly rotation#3577
Open
aurelj wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While configuring tracing-appender, I wanted to specify a monthly log rotation interval. I was unable to do so, as the largest rotation interval was weekly.
Solution
Before my introduction of monthly log rotation, the
next_date()function was straightforward: we could simply add a fixedDurationto the current date. However, we cannot do that for months as they do not all have the sameDuration.To go to next_month, we edit the current date, setting the month to next month and adding 1 to the year if next month is also crossing a year. We also need to set the day to 1 as the day of current date may not exist next month (eg. when current date is January 31st, next month can't be set to February 31st as this date is invalid). This gives us consistent date-times that is always during next month.