USWDS - 3.6.0: Npm audit fix#5461
Merged
Merged
Conversation
amyleadem
approved these changes
Aug 30, 2023
amyleadem
left a comment
Contributor
There was a problem hiding this comment.
Confirming that npm audit fix reduces the number of vulnerabilities as described in the PR description.
- Running
npm auditondevelopshows33 vulnerabilities (4 moderate, 29 high) - Running
npm audit fixondevelopshows30 vulnerabilities (1 moderate, 29 high) -
npm startruns without error and the build looks as expected
mejiaj
suggested changes
Sep 12, 2023
mejiaj
left a comment
Contributor
There was a problem hiding this comment.
@mahoneycm can you fix conflicts? Otherwise LGTM.
Contributor
Author
|
@mejiaj Conflicts resolved 👍 |
mejiaj
approved these changes
Sep 18, 2023
thisisdano
approved these changes
Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ran
npm audit fixondevelopbranch after3.6.0Vulnerabilities
Before
After
Breaking change
This is not a breaking change
Preview link
Preview link →
Testing and review