Skip to content

Creating a list of annotations allowed to treat package as annotated#1297

Closed
lwasylow wants to merge 6 commits into
developfrom
feature/issue_1278
Closed

Creating a list of annotations allowed to treat package as annotated#1297
lwasylow wants to merge 6 commits into
developfrom
feature/issue_1278

Conversation

@lwasylow

Copy link
Copy Markdown
Member

Resolve #1278

Root problem is the issue that package is being treated as annotate which allows it to be pushed into cache_suite table.
The solution is the do not treat object as annotated if the --% does not contain a valid annotation that is specified by framework.
e.g. ignore comments like --%parameter

This will allow for greater flexibility for documenting.

lwasylow added 4 commits April 4, 2025 19:47
Current issues is that any comment matching annotation --% is pushed into ut cache packages which causes exclusion from coverage reports.
@github-actions

github-actions Bot commented Apr 10, 2025

Copy link
Copy Markdown
Contributor

Unit Test Results

       1 files  ±  0         2 suites  ±0   2m 40s ⏱️ -48s
1 084 tests +26  1 080 ✔️ +26  4 💤 ±0  0 ±0 
1 088 runs  +26  1 080 ✔️ +26  8 💤 ±0  0 ±0 

Results for commit 463b84b. ± Comparison against base commit e872b30.

♻️ This comment has been updated with latest results.

@lwasylow lwasylow requested a review from jgebal April 10, 2025 19:41
@codecov

codecov Bot commented Apr 10, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.05%. Comparing base (45e3b57) to head (439d9be).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1297   +/-   ##
========================================
  Coverage    95.04%   95.05%           
========================================
  Files          111      111           
  Lines         5369     5377    +8     
  Branches        33       33           
========================================
+ Hits          5103     5111    +8     
  Misses         266      266           
Flag Coverage Δ
19se 95.10% <100.00%> (+<0.01%) ⬆️
21XE 95.25% <100.00%> (+<0.01%) ⬆️
23-free 94.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Test Results

    1 files    103 suites   2m 32s ⏱️
1 091 tests 1 087 ✅ 4 💤 0 ❌
1 095 runs  1 087 ✅ 8 💤 0 ❌

Results for commit 439d9be.

♻️ This comment has been updated with latest results.

@sonarqubecloud

sonarqubecloud Bot commented Mar 9, 2026

Copy link
Copy Markdown

@jgebal

jgebal commented Mar 15, 2026

Copy link
Copy Markdown
Member

This is not the correct way to solve this problem.
Annotation parsing must remain independent of suites.
This is by design.

There was an actual issue (A bug) in the suite cache management (not annotation cache)

I opened a separate PR to solve this problem. See #1313

@jgebal jgebal closed this Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Coverage not being reported when comment starts with --%param

2 participants