Lock node version to 18.16#52894
Merged
Merged
Conversation
ztanner
previously approved these changes
Jul 19, 2023
Contributor
|
Out of curiosity: what problem does this solve? |
Contributor
Author
|
@kachkaev updated in the description |
ijjk
approved these changes
Jul 19, 2023
styfle
approved these changes
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we're using nodejs with latest version of 18.x on CI, there's a new behavior change of
url.fileURLToPaththat didn't join the paths as expectedlocally with node 16.x or 18.16
in the actions runner with node 18.17 it's
You can see that
index.node.jsis still present in the path as a folder which is unexpected