Skip to content

fix(reactivity): handle effect removal during scope stop #15084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edison1105 merged 2 commits into from
Jul 16, 2026
+48 −8
Merged

fix(reactivity): handle effect removal during scope stop #15084

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59c0866
fix(reactivity): prevent crash when mutating effect scopes during tra…
Askerka00 Jul 14, 2026
300bc2f
fix(reactivity): handle effect removal during scope resume
edison1105 Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(reactivity): prevent crash when mutating effect scopes during tra… 
…versal
  • Loading branch information
@Askerka00
Askerka00 committed Jul 14, 2026
commit 59c086692b36fe859384074e33c37b2153bac804
15 changes: 9 additions & 6 deletions packages/reactivity/src/effectScope.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,9 @@ export class EffectScope {
this._isPaused = true
let i, l
if (this.scopes) {
for (i = 0, l = this.scopes.length; i < l; i++) {
this.scopes[i].pause()
const scopes = this.scopes.slice()
for (i = 0, l = scopes.length; i < l; i++) {
scopes[i].pause()
}
}
for (i = 0, l = this.effects.length; i < l; i++) {
Expand All @@ -89,8 +90,9 @@ export class EffectScope {
this._isPaused = false
let i, l
if (this.scopes) {
for (i = 0, l = this.scopes.length; i < l; i++) {
this.scopes[i].resume()
const scopes = this.scopes.slice()
for (i = 0, l = scopes.length; i < l; i++) {
scopes[i].resume()
}
}
for (i = 0, l = this.effects.length; i < l; i++) {
Expand Down Expand Up @@ -171,8 +173,9 @@ export class EffectScope {
this.cleanups.length = 0

if (this.scopes) {
for (i = 0, l = this.scopes.length; i < l; i++) {
this.scopes[i].stop(true)
const scopes = this.scopes.slice()
for (i = 0, l = scopes.length; i < l; i++) {
scopes[i].stop(true)
}
this.scopes.length = 0
}
Expand Down
Loading