Fix for "name required" for tab at 5.2.8.4 and 5.2.8.5#1771
Merged
Conversation
(name required) is missing for "tab" on 5.2.8.4 and 5.2.8.5. The query is searching the "Accessible Name Required:" value to be "True". There were extra spaces around that value so the string read "True " instead of "True".
scottaohara
approved these changes
Jul 20, 2022
scottaohara
left a comment
Member
There was a problem hiding this comment.
this does the trick. thanks
Contributor
|
@pkra I think we can merge this? |
Member
@spectranaut Is it ok for me to resolve the ipr failure as "non-substantial"? |
|
pkra marked as non substantive for IPR from ash-nazg. |
Member
|
I think this falls clearly in the "typos" category mentioned on the ipr page. |
pkra
pushed a commit
that referenced
this pull request
Jul 22, 2022
(name required) is missing for "tab" on 5.2.8.4 and 5.2.8.5. The query is searching the "Accessible Name Required:" value to be "True". There were extra spaces around that value so the string read "True " instead of "True".
jnurthen
pushed a commit
that referenced
this pull request
Oct 10, 2023
(name required) is missing for "tab" on 5.2.8.4 and 5.2.8.5. The query is searching the "Accessible Name Required:" value to be "True". There were extra spaces around that value so the string read "True " instead of "True".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses 1768
(name required) is missing for "tab" on 5.2.8.4 and 5.2.8.5. The query is searching the "Accessible Name Required:" value to be "True". There were extra spaces around that value so the string read "True " instead of "True".
Preview | Diff