fix: support multiline world declarations in wash wit add#5295
Merged
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
ricochet
reviewed
Jun 29, 2026
| pending_world = true; | ||
| if trimmed.contains('{') { | ||
| pending_world = false; | ||
| let next_indent = lines |
Contributor
There was a problem hiding this comment.
could be a helper since used twice, but this is good
ricochet
reviewed
Jun 29, 2026
|
|
||
| /// Test 1b: Add dependency when the world opening brace is on the next line | ||
| /// Verifies `wash wit add` handles valid multi-line world declarations | ||
| #[tokio::test] |
Contributor
There was a problem hiding this comment.
I think we can pair this one down to call insert_import_into_world(original_content, &import_line) directly. As a side benefit it would no longer need a tempdir or async file I/O, and can be converted to a plain #[test] and run in-memory.
ricochet
approved these changes
Jun 29, 2026
ricochet
left a comment
Contributor
There was a problem hiding this comment.
just left two nits. OK not to do those
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No linked issue, couldnt find a direct match.
wash wit addfails on validworld.witfiles when theworldopening brace is on the next line. It bails withCould not find a world block in world.wit to add the import, kinda rough.This makes the import insertion logic handle both brace styles, keeps new imports after the last existing import, and adds regression tests for the helper plus the real command path.
Repro:
wit/world.witwith:wash wit add wasi:logging/logging@0.1.0-draftCould not find a world block in world.wit to add the importworldblock and the command keeps going