Don’t generate invalid meta tags in <head>#3496
Merged
Merged
Conversation
…3420) Co-authored-by: Chris Swithinbank <swithinbank@gmail.com> Co-authored-by: trueberryless <99918022+trueberryless@users.noreply.github.com>
🦋 Changeset detectedLatest commit: fb12d2b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
size-limit report 📦
|
…th missing href" solution (#3501) Co-authored-by: Anders Kaseorg <andersk@mit.edu> Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
This was referenced Nov 9, 2025
…getRouteDataTestContext, getTestHead) (#3544)
<link rel="canonical"/> with missing href<head>
HiDeoo
reviewed
Nov 10, 2025
HiDeoo
left a comment
Member
There was a problem hiding this comment.
Left a few minor comments, but otherwise this is looking really great.
Thanks to everyone involved, amazing job on fixing that issue 🙌
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
delucis
commented
Nov 10, 2025
HiDeoo
approved these changes
Nov 11, 2025
HiDeoo
left a comment
Member
There was a problem hiding this comment.
Thanks for the update, looks ready to me 🚀
Merged
gxxxr-111
pushed a commit
to gxxxr-111/starlight
that referenced
this pull request
Apr 9, 2026
Co-authored-by: Anders Kaseorg <andersk@mit.edu> Co-authored-by: trueberryless <99918022+trueberryless@users.noreply.github.com> Co-authored-by: nemu <58832428+erbierc@users.noreply.github.com> Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR to #3420 which was merged into this intermediate branch to allow @erbierc to pick up work on adding tests.
Opening as a draft for now until we have those tests!