Skip to content

Add Travis build with all-features to current (with default features)#27

Merged
zbraniecki merged 1 commit into
zbraniecki:masterfrom
hjmallon:travis-all-faetures
Oct 28, 2019
Merged

Add Travis build with all-features to current (with default features)#27
zbraniecki merged 1 commit into
zbraniecki:masterfrom
hjmallon:travis-all-faetures

Conversation

@hjmallon

@hjmallon hjmallon commented Oct 18, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

#26

@hjmallon

hjmallon commented Oct 18, 2019

Copy link
Copy Markdown
Contributor Author

This seems to work - ish. However this change could scupper it rust-lang/cargo#7507

Maybe there is a better way to pick the features on the sub projects?

@hjmallon hjmallon mentioned this pull request Oct 18, 2019
Closed
zbraniecki
zbraniecki reviewed Oct 18, 2019
View reviewed changes
Comment thread .travis.yml
@zbraniecki

zbraniecki commented Oct 18, 2019

Copy link
Copy Markdown
Owner

this doesn't complete on travis?

@hjmallon

hjmallon commented Oct 18, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

It doesn't complete on Travis because:

  1. Nightly blocked the --all-features flag on workspaces recently (they reverted that here Allow --all-features in root of virtual workspace. rust-lang/cargo#7525)
  2. Tests don't pass with --all-features enabled. There is something failing in remove-likely-subtags. I haven't looked into it further though.

I figured I would leave it as WIP until it passed.

@hjmallon hjmallon force-pushed the travis-all-faetures branch 2 times, most recently from 505873e to f4c6f22 Compare October 20, 2019 01:43
@hjmallon

hjmallon commented Oct 20, 2019

Copy link
Copy Markdown
Contributor Author

#28 PR fixes the cargo test --all-features failing (point 2 above).
Hopefully tonight's nightly will fix point 1 above.

@hjmallon hjmallon force-pushed the travis-all-faetures branch from f4c6f22 to c7224b6 Compare October 21, 2019 19:18
@hjmallon hjmallon changed the title WIP: Test matrix on Travis including --all-features Add Travis build with all-features to current (with default features) Oct 21, 2019
@hjmallon hjmallon force-pushed the travis-all-faetures branch 2 times, most recently from 950560f to 601d6a0 Compare October 22, 2019 20:08
@hjmallon

hjmallon commented Oct 23, 2019

Copy link
Copy Markdown
Contributor Author

Still waiting for a cargo nightly after the one below. I am not sure how to check when those happen but I'm happy to wait a few days (it should be soon?).

% cargo -V
cargo 1.40.0-nightly (3a9abe3f0 2019-10-15)

@hjmallon hjmallon force-pushed the travis-all-faetures branch from 601d6a0 to 2f45413 Compare October 27, 2019 03:47
@hjmallon

hjmallon commented Oct 27, 2019

Copy link
Copy Markdown
Contributor Author

I am now happy with this and it is passing CI.

@zbraniecki

zbraniecki commented Oct 28, 2019

Copy link
Copy Markdown
Owner

excellent! Thank you!

@zbraniecki zbraniecki merged commit 4b80b19 into zbraniecki:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zbraniecki zbraniecki zbraniecki left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hjmallon @zbraniecki