fix(ssr): dedupe inherited scope ids during vnode rendering by edison1105 · Pull Request #15005 · vuejs/core

edison1105 · 2026-06-25T03:07:18Z

Summary by CodeRabbit

Bug Fixes
- Fixed duplicate scope identifiers in server-rendered output for recursive component and root rendering cases.
- Improved handling of inherited and slot-related scope IDs so they are only applied once, preventing repeated attributes in rendered HTML.
Tests
- Added coverage for recursive SSR scenarios to verify scope IDs remain unique in the final output.

coderabbitai · 2026-06-25T03:07:33Z

📝 Walkthrough

Walkthrough

SSR element rendering now avoids appending duplicate scope IDs, and the SSR scopeId spec adds recursive component-root cases that verify a single comp scopeId in the output.

Changes

SSR scopeId de-duplication

Layer / File(s)	Summary
Renderer deduplication `packages/server-renderer/src/render.ts`	`renderElementVNode` now appends scope IDs through a deduplicating path that skips IDs already present on `props` or already emitted.
Recursive scopeId tests `packages/server-renderer/__tests__/ssrScopeId.spec.ts`	The SSR scopeId spec imports `ssrRenderVNode` and adds recursive `ssrRenderComponent` and `render()` cases that assert one `comp` scopeId in the output.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

:hammer: p3-minor-bug

Poem

A rabbit hopped through SSR rain,
and scopeIds danced, then settled կրկain.
One tag, one hop, no duplicates found,
just tidy paws on server ground.
(_/ )✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the SSR scope-id deduplication fix introduced by the patch.
Linked Issues check	✅ Passed	The render change and added recursion tests address the duplicate scoped attribute bug described in `#12159` and `#12175`.
Out of Scope Changes check	✅ Passed	The changes are focused on SSR scope-id deduplication and matching tests, with no unrelated code introduced.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch edison/fix/ssr-scope-id-dedupe

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-06-25T03:08:25Z

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	106 kB	40.2 kB	36.1 kB
vue.global.prod.js	164 kB	60.2 kB	53.5 kB

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	48.8 kB	19 kB	17.4 kB
createApp	56.9 kB	22 kB	20.1 kB
createSSRApp	61.2 kB	23.8 kB	21.7 kB
defineCustomElement	63.1 kB	23.9 kB	21.8 kB
overall	71.7 kB	27.4 kB	25 kB

pkg-pr-new · 2026-06-25T03:08:37Z

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@15005

npm i https://pkg.pr.new/@vue/compiler-core@15005

yarn add https://pkg.pr.new/@vue/compiler-core@15005.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@15005

npm i https://pkg.pr.new/@vue/compiler-dom@15005

yarn add https://pkg.pr.new/@vue/compiler-dom@15005.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@15005

npm i https://pkg.pr.new/@vue/compiler-sfc@15005

yarn add https://pkg.pr.new/@vue/compiler-sfc@15005.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@15005

npm i https://pkg.pr.new/@vue/compiler-ssr@15005

yarn add https://pkg.pr.new/@vue/compiler-ssr@15005.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@15005

npm i https://pkg.pr.new/@vue/reactivity@15005

yarn add https://pkg.pr.new/@vue/reactivity@15005.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@15005

npm i https://pkg.pr.new/@vue/runtime-core@15005

yarn add https://pkg.pr.new/@vue/runtime-core@15005.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@15005

npm i https://pkg.pr.new/@vue/runtime-dom@15005

yarn add https://pkg.pr.new/@vue/runtime-dom@15005.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@15005

npm i https://pkg.pr.new/@vue/server-renderer@15005

yarn add https://pkg.pr.new/@vue/server-renderer@15005.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@15005

npm i https://pkg.pr.new/@vue/shared@15005

yarn add https://pkg.pr.new/@vue/shared@15005.tgz

vue

pnpm add https://pkg.pr.new/vue@15005

npm i https://pkg.pr.new/vue@15005

yarn add https://pkg.pr.new/vue@15005.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@15005

npm i https://pkg.pr.new/@vue/compat@15005

yarn add https://pkg.pr.new/@vue/compat@15005.tgz

commit: 695494d

edison1105 · 2026-06-25T03:08:51Z

/ecosystem-ci run

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/server-renderer/src/render.ts`:
- Around line 307-317: appendScopeId in render.ts is skipping scope IDs based
only on hasOwn(props, id), which does not match the SSR attr renderability rules
used by ssrRenderAttrs. Update the predicate to mirror the same check used for
rendering attrs so scope IDs are only skipped when the prop would actually be
rendered, and keep the existing renderedScopeIds de-duplication logic intact.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cdf5d28e-646a-46ea-a552-cabd7325d99d

📥 Commits

Reviewing files that changed from the base of the PR and between 325eb1d and 695494d.

📒 Files selected for processing (2)

packages/server-renderer/__tests__/ssrScopeId.spec.ts
packages/server-renderer/src/render.ts

vue-bot · 2026-06-25T03:28:18Z

📝 Ran ecosystem CI: Open

suite	result	latest scheduled
pinia	✅ success	✅ success
radix-vue	❌ failure	❌ failure
quasar	✅ success	✅ success
language-tools	✅ success	✅ success
primevue	✅ success	✅ success
vant	✅ success	✅ success
vue-i18n	✅ success	✅ success
nuxt	✅ success	✅ success
vue-macros	✅ success	✅ success
vitepress	✅ success	❌ failure
router	✅ success	✅ success
test-utils	✅ success	✅ success
vue-simple-compiler	✅ success	❌ failure
vite-plugin-vue	✅ success	❌ failure
vuetify	✅ success	❌ failure
vueuse	✅ success	✅ success

This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [vue](https://vuejs.org/) ([source](https://github.com/vuejs/core)) | [`3.5.38` → `3.5.39`](https://renovatebot.com/diffs/npm/vue/3.5.38/3.5.39) | ![age](https://developer.mend.io/api/mc/badges/age/npm/vue/3.5.39?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/vue/3.5.38/3.5.39?slim=true) | --- ### Release Notes <details> <summary>vuejs/core (vue)</summary> ### [`v3.5.39`](https://github.com/vuejs/core/blob/HEAD/CHANGELOG.md#3539-2026-06-25) [Compare Source](vuejs/core@v3.5.38...v3.5.39) ##### Bug Fixes - **compiler-core:** correct filter rewrite recursion ([#14959](vuejs/core#14959)) ([be7ce31](vuejs/core@be7ce31)) - **hydration:** force patch dynamic props when hydrating ([#9083](vuejs/core#9083)) ([024cf06](vuejs/core@024cf06)), closes [#9033](vuejs/core#9033) - **hydration:** respect data-allow-mismatch on conditional branches ([#12801](vuejs/core#12801)) ([164af63](vuejs/core@164af63)), closes [#12782](vuejs/core#12782) - **reactivity:** avoid triggering effects when set fails ([#14964](vuejs/core#14964)) ([e450973](vuejs/core@e450973)) - **runtime-core:** handle non-isomorphic block element update ([#15002](vuejs/core#15002)) ([932ddd0](vuejs/core@932ddd0)), closes [#6385](vuejs/core#6385) - **runtime-core:** normalize function children for elements and Teleport ([#9108](vuejs/core#9108)) ([2f374cd](vuejs/core@2f374cd)), closes [#9107](vuejs/core#9107) - **runtime-core:** pause tracking when invoking function refs ([#14985](vuejs/core#14985)) ([3ac052b](vuejs/core@3ac052b)) - **runtime-core:** preserve once event listener name ([#8341](vuejs/core#8341)) ([87b73b6](vuejs/core@87b73b6)), closes [#8342](vuejs/core#8342) - **runtime-dom:** preserve option modifier event names ([#8338](vuejs/core#8338)) ([4b659e6](vuejs/core@4b659e6)), closes [#8334](vuejs/core#8334) - **ssr:** dedupe inherited scope ids during vnode rendering ([#15005](vuejs/core#15005)) ([027da6b](vuejs/core@027da6b)), closes [#12159](vuejs/core#12159) [#12175](vuejs/core#12175) - **ssr:** resolve nested async teleport content ([#9431](vuejs/core#9431)) ([31d0f23](vuejs/core@31d0f23)), closes [#6207](vuejs/core#6207) - **teleport:** handle teleport unmount edge case ([#12705](vuejs/core#12705)) ([671997a](vuejs/core@671997a)), closes [#12702](vuejs/core#12702) - **types:** support named tuple emits ([#12676](vuejs/core#12676)) ([232f402](vuejs/core@232f402)), closes [#12673](vuejs/core#12673) - **types:** validate defineModel defaults ([#14968](vuejs/core#14968)) ([747f57e](vuejs/core@747f57e)), closes [#14966](vuejs/core#14966) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).  Co-authored-by: leuwen-lc <leuwen-lc@noreply.codeberg.org> Reviewed-on: https://codeberg.org/leuwen-lc/rhdemo/pulls/180

fix(ssr): dedupe inherited scope ids during vnode rendering

695494d

close #12159 close #12175

edison1105 added ready to merge The PR is ready to be merged. scope: ssr labels Jun 25, 2026

coderabbitai Bot reviewed Jun 25, 2026

View reviewed changes

Comment thread packages/server-renderer/src/render.ts

edison1105 merged commit 027da6b into main Jun 25, 2026
16 checks passed

edison1105 deleted the edison/fix/ssr-scope-id-dedupe branch June 25, 2026 08:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(ssr): dedupe inherited scope ids during vnode rendering#15005

fix(ssr): dedupe inherited scope ids during vnode rendering#15005
edison1105 merged 1 commit into
mainfrom
edison/fix/ssr-scope-id-dedupe

edison1105 commented Jun 25, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 25, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Suggested labels

Poem

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Jun 25, 2026

Uh oh!

pkg-pr-new Bot commented Jun 25, 2026

Uh oh!

edison1105 commented Jun 25, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

vue-bot commented Jun 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

edison1105 commented Jun 25, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested labels

Poem

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Jun 25, 2026

Size Report

Bundles

Usages

Uh oh!

pkg-pr-new Bot commented Jun 25, 2026

Uh oh!

edison1105 commented Jun 25, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vue-bot commented Jun 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

edison1105 commented Jun 25, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 25, 2026 •

edited

Loading