[Port] Eliminate unnecessary call to CheckBlock#520
Closed
kyuupichan wants to merge 1 commit into
Closed
Conversation
Collaborator
|
@kyuupichan you need to rebase all your PR's on the new dev...there are new fixes to the tests that everyone needs. |
Contributor
Author
|
Yeah shame there is no rerun Travis button |
Collaborator
|
@kyuupichan there's a "button" to restart travis build, you need write permission to use it thou. if you need to restart a build you have 3 way of doing it:
|
ProcessNewBlock would return failure early if CheckBlock failed, before calling AcceptBlock. AcceptBlock also calls CheckBlock, and upon failure would update mapBlockIndex to indicate that a block was failed. By returning early in ProcessNewBlock, we were not marking blocks that fail a check in CheckBlock as permanently failed, and thus would continue to re-request and reprocess them.
Contributor
Author
|
Closing this because of bitcoin/bitcoin#9765. This whole area needs a cleanup, which is now on my to-do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From bitcoin#7225:
For the reasons stated in the comments to the core PR, I think we should review the purpose and usefulness of the CheckBlockHeader call we have at the top of ProcessNewBlock and perhaps move the SendExpeditedBlock call to a more appropriate place, I don't think the current position is optimal. But that's for a later PR once this is accepted.