Harden against mistakes handling invalid blocks#9765
Merged
Conversation
Fixes a bug in AcceptBlock() in invoking CheckBlock() with incorrect arguments, and restores a call to CheckBlock() from ProcessNewBlock() as belt-and-suspenders. Updates the (overspecified) tests to match behavior.
Contributor
|
utACK ba803ef |
Contributor
|
Also this is a bug fix that should be tagged 0.14 in my opinion |
Member
|
Grr, we really shouldn't have default arguments in consensus code. utACK ba803ef. |
Member
|
utACK ba803ef
Bitfields/Enumerations instead of bool, bool, bool, ... also tends to help make code like this more readable and thus reviewable. Multiple boolean parameters to a function make code hard to understand, always have to look at the signature to find out which one is what. |
laanwj
added a commit
that referenced
this pull request
Feb 16, 2017
ba803ef Harden against mistakes handling invalid blocks (Suhas Daftuar)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Feb 8, 2018
ba803ef Harden against mistakes handling invalid blocks (Suhas Daftuar)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
ba803ef Harden against mistakes handling invalid blocks (Suhas Daftuar)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 28, 2019
ba803ef Harden against mistakes handling invalid blocks (Suhas Daftuar)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in AcceptBlock() in invoking CheckBlock() with incorrect
arguments (introduced in #8068), and restores a call to CheckBlock() from ProcessNewBlock()
as belt-and-suspenders (effectively reverting #7225).
Updates the (overspecified) tests to match the slight behavior change (different reject code).